Some late feedback on 'Contribute to Guide' PR #109 #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply GBKS's suggestions. Co-authored-by: Christoph Ono <[email protected]>
Co-authored-by: Christoph Ono <[email protected]>
added 13 commits
January 15, 2021 10:39
This reverts commit 6b0ed53.
Contributor
Author
|
If/When this PR gets merged, please squash the commits as there it is a bit 'unclean', containing commits already merged. Reason: I branched off a PR that was already merged (unbeknownst to me). I then merged master into that branch to make sure there were no conflicts. But the previous commits still show up on this PR. |
pavlenex
approved these changes
Jan 15, 2021
Contributor
pavlenex
left a comment
pavlenex
left a comment
There was a problem hiding this comment.
Just a note, since this PR is based of my earlier PR and not the master, it would be a good idea to squash commits when merging this PR.
added 3 commits
January 15, 2021 12:16
pavlenex
approved these changes
Jan 15, 2021
Contributor
pavlenex
left a comment
pavlenex
left a comment
There was a problem hiding this comment.
Thanks for quickly addressing the navigation and for all the improvements to the page.
GBKS
reviewed
Jan 15, 2021
GBKS
reviewed
Jan 15, 2021
GBKS
reviewed
Jan 15, 2021
Co-authored-by: Christoph Ono <[email protected]>
Co-authored-by: Christoph Ono <[email protected]>
Co-authored-by: Christoph Ono <[email protected]>
GBKS
approved these changes
Jan 15, 2021
johnsBeharry
approved these changes
Jan 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was too slow to comment on it before the merge but here are some tweaks.
Apart from fixed typos and some simplified language the main changes are: