Added allowance for argument zero_terms_query to be any case. Allowed…

[MitchellGale]

Signed-off-by: Mitchell Gale [email protected]

Description

Allows for any case on argument name for relevancy based function (Match Phrase Prefix, Simple Query String, Match Bool Prefix, Match, Multi-Match, Query String, Relevance, Simple Query String).
e.g.
AnalyZer can work instead of just analyzer
Zero_Terms_Query can work instead of just zero_terms_query
BOOst can work instead of just boost

Allows for zero_term_query arguments to be of any case.
e.g.
All can work instead of all

Check List

• New functionality includes testing.
  • All tests pass, including unit test, integration test and doctest
• New functionality has been documented.
  • New functionality has javadoc added
  • New functionality has user manual doc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[acarbonetto]

The isLowerCase may fail if arg.getArgName() doesn't exist.

[Yury-Fridlyand]

SQL/PPL parser is already case-insensitive. The goal is to change case for some parameter values.
See example from main:

opensearchsql> select * from logs where simple_query_string(['*'], 'CLR', AnAlYZer = 'standard');
Output longer than terminal width
Do you want to display data vertically for better visual effect? [y/N]: y
opensearchsql> select * from logs where simple_query_string(['*'], 'CLR', analyzer = 'stAndaRd');
TransportError(500, 'SearchPhaseExecutionException', {'error': {'type': 'SearchPhaseExecutionException', 'reason': 'Error occurred in OpenSearch engine: all shards failed', 'details': 'Shard[0]: [logs/uHvAufvyREut9LnosEX2yg] QueryShardException[[simple_query_string] analyzer [stAndaRd] not found]\n\nFor more details, please send request for Json format to see the raw response from OpenSearch engine.'}, 'status': 503})

So all calls for analyzer's value should be wrapped by .toLower():

.put("analyzer", (b, v) -> b.analyzer(v.stringValue()))

like you did for ZeroTermsQuery and Flags. Boost has double type, nothing to convert there, but what about Operator, DefaultOperator and so on?

[MaxKsyunz]

@MitchellGale-BitQuill the conflicts need to be resolved and SQL Java CI should pass as well.

[codecov]

Codecov Report

Merging #95 (8c49d05) into Integ-RelFunc_changeCaseWhereAppropriate (5c6fd72) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@                              Coverage Diff                               @@
##             Integ-RelFunc_changeCaseWhereAppropriate      #95      +/-   ##
==============================================================================
+ Coverage                                       97.74%   97.77%   +0.02%     
- Complexity                                       2858     2882      +24     
==============================================================================
  Files                                             273      276       +3     
  Lines                                            7020     7086      +66     
  Branches                                          442      447       +5     
==============================================================================
+ Hits                                             6862     6928      +66     
  Misses                                            157      157              
  Partials                                            1        1              

Flag	Coverage Δ
sql-engine	97.77% <100.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ensearch/sql/planner/physical/PhysicalPlanDSL.java	100.00% <ø> (ø)
.../sql/planner/physical/PhysicalPlanNodeVisitor.java	100.00% <ø> (ø)
...ain/java/org/opensearch/sql/analysis/Analyzer.java	100.00% <100.00%> (ø)
...rg/opensearch/sql/analysis/ExpressionAnalyzer.java	100.00% <100.00%> (ø)
...org/opensearch/sql/analysis/HighlightAnalyzer.java	100.00% <100.00%> (ø)
...ensearch/sql/expression/ExpressionNodeVisitor.java	100.00% <100.00%> (ø)
...opensearch/sql/expression/HighlightExpression.java	100.00% <100.00%> (ø)
...h/sql/expression/function/BuiltinFunctionName.java	100.00% <100.00%> (ø)
...h/sql/expression/function/OpenSearchFunctions.java	100.00% <100.00%> (ø)
...ensearch/sql/planner/logical/LogicalHighlight.java	100.00% <100.00%> (ø)
... and 14 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[MitchellGale]

#103 PR remade in 103