Skip to content

Conversation

@MitchellGale
Copy link

Description

Allows for any case on argument name for relevancy based function (Match Phrase Prefix, Simple Query String, Match Bool Prefix, Match, Multi-Match, Query String, Relevance, Simple Query String).
e.g.
AnalyZer can work instead of just analyzer
Zero_Terms_Query can work instead of just zero_terms_query
BOOst can work instead of just boost

Allows for zero_term_query arguments to be of any case.
e.g.
All can work instead of ALL

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…elevancy based functions. Added unit tests to cover updates.

Signed-off-by: MitchellGale-BitQuill <[email protected]>
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #103 (5d146f2) into integ-RelFunc_changeCaseWhereAppropriate (29f1c52) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@                             Coverage Diff                             @@
##             integ-RelFunc_changeCaseWhereAppropriate     #103   +/-   ##
===========================================================================
  Coverage                                       94.78%   94.79%           
- Complexity                                       2880     2882    +2     
===========================================================================
  Files                                             286      286           
  Lines                                            7735     7741    +6     
  Branches                                          565      565           
===========================================================================
+ Hits                                             7332     7338    +6     
  Misses                                            349      349           
  Partials                                           54       54           
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine 97.76% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ilter/lucene/relevance/MatchPhrasePrefixQuery.java 100.00% <100.00%> (ø)
...ript/filter/lucene/relevance/MatchPhraseQuery.java 100.00% <100.00%> (ø)
...age/script/filter/lucene/relevance/MatchQuery.java 100.00% <100.00%> (ø)
...cript/filter/lucene/relevance/MultiMatchQuery.java 100.00% <100.00%> (ø)
...ript/filter/lucene/relevance/QueryStringQuery.java 100.00% <100.00%> (ø)
...script/filter/lucene/relevance/RelevanceQuery.java 100.00% <100.00%> (ø)
...ilter/lucene/relevance/SimpleQueryStringQuery.java 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@MitchellGale MitchellGale merged commit d7fe5c6 into integ-RelFunc_changeCaseWhereAppropriate Aug 9, 2022
@Yury-Fridlyand Yury-Fridlyand deleted the dev-RelFunc_changeCaseWhereAppropriate2 branch January 12, 2023 19:46
andy-k-improving pushed a commit that referenced this pull request Nov 16, 2024
Signed-off-by: Vijayan Balasubramanian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants