Repository navigation
chore(release): backport part of #43902 and #43983 to rc/1.104.0 - #44332
Conversation
…ted contracts (#43902) Partial backport to rc/1.104.0: only the text completion endpoint test moves off the deprecated gpt-3.5-turbo-instruct to openai/gpt-5.4-nano. The SAIL, spend-log and coverage registry repairs target tests or behavior this line does not need for the e2e suite (cherry picked from commit e61733b)
Partial backport to rc/1.104.0: only the Together AI structured-output e2e case moves to the hybrid reasoning backend with reasoning off, since the reasoning-only model it picked returned no content. The CI infrastructure and other test repairs are not needed for this line's e2e suite (cherry picked from commit 6ca90b9)
|
| model, | ||
| LiteLLMParamsBody( | ||
| model="text-completion-openai/gpt-3.5-turbo-instruct", | ||
| model="openai/gpt-5.4-nano", |
There was a problem hiding this comment.
Native completion coverage lost
Registering openai/gpt-5.4-nano makes this test use the chat-model adapter behind /v1/completions, not the native text-completion-openai adapter it previously tested. No live E2E test now covers that native path, so a regression there could pass the suite. The repository requires changes to existing tests not to weaken regression coverage; please preserve a live check for the native path before merging.
Rule Used: What: Flag any modifications to existing tests and verify they don't weaken test coverage or mask regressions. Why: Developers may alter tests to make failing code pass rather than fix the actual bug, hiding regressions. Good: ``` // Test updated t... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
TLDR
Problem this solves:
gpt-3.5-turbo-instruct, OpenAI returns 404How it solves it:
-xUser Flow
Before: the rc/1.104.0 e2e suite stays red on two tests no retry can fix
test_text_completion_returns_textfails with a 404 sayinggpt-3.5-turbo-instructhas been deprecatedtest_response_format_json_schema_shapes_the_replyfails withcontent=Nonefromtogether_ai/zai-org/GLM-5.3-FlashAfter: the same pipeline no longer hits either failure
openai/gpt-5.4-nanowith reasoning off and gets text backtogether_ai/Qwen/Qwen3.5-9Bwith reasoning off and gets schema-shaped JSONRelevant issues
Backports part of #43902 and part of #43983 to rc/1.104.0 so the e2e suite can go green before the next 1.104.0 release candidate. Test-only, no version bump
What is included, in order:
tests/e2e/llm_translation/test_completions_endpoint_e2e.py)tests/e2e/llm_translation/test_together_ai_e2e.py)Pre-Submission checklist
Screenshots / Proof of Fix
Local proxy started from this branch with this config (master key redacted), hitting real OpenAI:
Before (31d6c60)
Text completion
2 failed, 2 passed, the two failures aretest_text_completion_returns_textandtest_response_format_json_schema_shapes_the_replyTogether structured output
AssertionError: together_ai/zai-org/GLM-5.3-Flash returned no content: role='assistant' content=None reasoning_content='The user wants me to invent a fictional person...'After (ddd3c48)
Text completion
Together structured output
Type
Test
Caveats (if any)
Low
QA runbook
model: openai/gpt-5.4-nano(needs OPENAI_API_KEY)max_tokens: 16andreasoning_effort: "none"object: "text_completion"and non-emptychoices[0].textmodel: together_ai/Qwen/Qwen3.5-9B(needs TOGETHERAI_API_KEY)max_tokens: 1024,reasoning_effort: "none"and a json_schema response_format with anamefieldchoices[0].message.contentto be JSON matching the schema with a non-emptynameFinal Attestation