revert: "feat(usage): search keys beyond the top-N usage subset (#42827)" by yassin-berriai · Pull Request #43378 · BerriAI/litellm

yassin-berriai · 2026-09-26T23:46:58Z

Reverts #42827

TLDR

Problem this solves:

feat(usage): search keys beyond the top-N usage subset #42827 (server-side key search beyond the top-N on the Usage page) needs to come back out of main

How it solves it:

Plain git revert of the squash commit 5a8ec13, no conflicts
Removes the GET /user/daily/activity/aggregated/search route, its types, tests and the Key Activity panel's remote search

User Flow

Before: on Usage > Key Activity, typing the alias of a key below the top 100 finds it through a server search

They open http://localhost:4000/ui/?page=usage, open Key Activity and type the alias
The dashboard calls GET http://localhost:4000/user/daily/activity/aggregated/search?search=... and shows the key

After: the page behaves as it did before #42827

They open http://localhost:4000/ui/?page=usage, open Key Activity and type the alias
The search filters only the loaded top-N keys and reports "No keys match"; GET http://localhost:4000/user/daily/activity/aggregated/search returns 404

Type

🧹 Refactoring

Caveats (if any)

Low

Last of the three PR revert stack, on top of the feat(usage): search team keys beyond the top-N in the Team usage view #42857 revert, which itself sits on the feat(proxy): server-side Team Usage export beyond the top-N key cap #42996 revert; GitHub retargets it as each one merges

🤖 Generated with Claude Code

CLAassistant · 2026-09-26T23:47:04Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ devin-ai-integration[bot]
❌ yassin-berriai
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

greptile-apps · 2026-09-26T23:49:35Z

Confidence Score: 4/5

[Medium risk] Removes a search feature from the usage tracking API.

The PR should not merge as-is because it removes existing key-search behavior without the user-controlled compatibility option required by the repository.

Findings

Key search misses existing keys ▶

Summary

The PR reverts server-side Key Activity search beyond the loaded top-N keys, removing its proxy route, dashboard integration, types, and tests.

The dashboard returns to filtering only loaded keys.
The search API is no longer available.

_{Reviews (1) · Last reviewed commit: "Revert "feat(usage): search keys beyond ..."}

greptile-apps · 2026-09-26T23:49:38Z

-                    apiKeyTruncation={spendFetchState.apiKeyTruncation}
-                    searchKeys={searchKeys}
-                  />
+                  <KeyActivityPanel keyMetrics={keyMetrics} apiKeyTruncation={spendFetchState.apiKeyTruncation} />


Key search misses existing keys

When more keys have activity than the top-N limit, this panel now searches only the loaded keys. Searching for an existing lower-spend key therefore shows “No keys match.” This revert also removes the search API, so existing clients calling it receive a 404. The repository requires avoiding backwards-incompatible changes without a user-controlled flag, but this revert provides no way to retain the previous behavior.

Rule Used: What: avoid backwards-incompatible changes without user-controlled flags Why: This breaks current behaviour for users using existing functionality Example of BAD: this PR (#22164) introduced run_post_custom... (source)

codecov · 2026-09-27T00:02:29Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

…r the usage dashboard (#41324)" (#43595) * Revert "Merge pull request #41324 from BerriAI/litellm_daily_global_spend_table" * Revert "Merge pull request #41293 from BerriAI/litellm_usage_key_free_aggregate_split" (#43596) Co-authored-by: yassin <yassin@berri.ai> --------- Co-authored-by: yassin <yassin@berri.ai> Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>

veria-ai · 2026-09-28T21:43:35Z

        WHERE {where_clause}
        GROUP BY GROUPING SETS (
+            (date),
            (date, api_key),


Low: Unbounded per-key usage response

An authenticated user can request aggregated activity for a key-heavy user or team and force the proxy to materialize every per-key grouping row, look up metadata for every distinct key, and serialize the full result without pagination. Repeated requests against a large history can exhaust worker memory. Keep the overall totals complete, but bound or paginate the per-key breakdowns separately.

veria-ai · 2026-09-28T21:43:42Z

PR overview

This PR reverts the change that searched usage keys beyond the top-N usage subset. The affected code handles daily activity aggregation and per-key usage breakdowns.

One issue remains open: an authenticated user can request a large per-key activity breakdown that is materialized and returned without a bound or pagination. Repeated requests for key-heavy users or teams could exhaust proxy worker memory. No issues have been addressed yet.

Open issues (1)

Low: Unbounded per-key usage response — litellm/proxy/management_endpoints/common_daily_activity.py:793

Fixed/addressed: 0 · PR risk: 5/10

…sage view (#42857)" (#43377) * Revert "feat(usage): search team keys beyond the top-N in the Team usage view (#42857)" * revert: "feat(usage): search keys beyond the top-N usage subset (#42827)" (#43378) * Revert "feat(usage): search keys beyond the top-N usage subset (#42827)" * revert: "feat(proxy): add LiteLLM_DailyGlobalSpend key-free rollup for the usage dashboard (#41324)" (#43595) * Revert "Merge pull request #41324 from BerriAI/litellm_daily_global_spend_table" * Revert "Merge pull request #41293 from BerriAI/litellm_usage_key_free_aggregate_split" (#43596) Co-authored-by: yassin <yassin@berri.ai> --------- Co-authored-by: yassin <yassin@berri.ai> Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> --------- Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> --------- Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>

yassin-berriai requested review from ryan-crabbe-berri and yuneng-berri as code owners September 26, 2026 23:46

yassin-berriai had a problem deploying to e2e-changed September 26, 2026 23:47 — with GitHub Actions Error

greptile-apps Bot reviewed Sep 26, 2026

View reviewed changes

devin-ai-integration Bot had a problem deploying to e2e-changed September 27, 2026 00:17 Error

devin-ai-integration Bot mentioned this pull request Sep 28, 2026

revert: "feat(proxy): add LiteLLM_DailyGlobalSpend key-free rollup for the usage dashboard (#41324)" #43595

Merged

2 tasks done

devin-ai-integration Bot force-pushed the litellm_revert_42857 branch from 2b00ce9 to 0ac3f5b Compare September 28, 2026 19:41

devin-ai-integration Bot force-pushed the litellm_revert_42827 branch from 05784eb to 5aafae2 Compare September 28, 2026 19:41

devin-ai-integration Bot had a problem deploying to e2e-changed September 28, 2026 19:41 Error

devin-ai-integration Bot had a problem deploying to e2e-changed September 28, 2026 20:34 Error

devin-ai-integration Bot force-pushed the litellm_revert_42857 branch from 4337d93 to 04633e2 Compare September 28, 2026 21:25

devin-ai-integration Bot force-pushed the litellm_revert_42827 branch from a1b7975 to 32bc265 Compare September 28, 2026 21:25

devin-ai-integration Bot had a problem deploying to e2e-changed September 28, 2026 21:25 Error

Revert "feat(usage): search keys beyond the top-N usage subset (#42827)"

b5aa93a

devin-ai-integration Bot force-pushed the litellm_revert_42857 branch from 04633e2 to a12070b Compare September 28, 2026 21:27

devin-ai-integration Bot requested review from kerry-berri and mateo-berri as code owners September 28, 2026 21:27

devin-ai-integration Bot force-pushed the litellm_revert_42827 branch from 32bc265 to b5aa93a Compare September 28, 2026 21:27

devin-ai-integration Bot had a problem deploying to e2e-changed September 28, 2026 21:27 Error

yuneng-berri requested a deployment to e2e-changed September 28, 2026 21:40 — with GitHub Actions Waiting

yuneng-berri merged commit 1903cec into litellm_revert_42857 Sep 28, 2026
49 of 53 checks passed

yuneng-berri deleted the litellm_revert_42827 branch September 28, 2026 21:40

veria-ai Bot reviewed Sep 28, 2026

View reviewed changes

Navigation Menu

Repository navigation

revert: "feat(usage): search keys beyond the top-N usage subset (#42827)" - #43378

revert: "feat(usage): search keys beyond the top-N usage subset (#42827)"#43378
yuneng-berri merged 2 commits into
litellm_revert_42857from
litellm_revert_42827

yassin-berriai commented Sep 26, 2026

Uh oh!

CLAassistant commented Sep 26, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Sep 26, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot Sep 26, 2026

Uh oh!

codecov Bot commented Sep 27, 2026 •

edited

Loading

Uh oh!

Uh oh!

veria-ai Bot Sep 28, 2026

Uh oh!

veria-ai Bot commented Sep 28, 2026

Uh oh!

This branch is waiting to be deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

yassin-berriai commented Sep 26, 2026

TLDR

User Flow

Type

Caveats (if any)

Low

Uh oh!

CLAassistant commented Sep 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Sep 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 4/5

Findings

Summary

Uh oh!

greptile-apps Bot Sep 26, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Sep 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

veria-ai Bot Sep 28, 2026

Choose a reason for hiding this comment

Uh oh!

veria-ai Bot commented Sep 28, 2026

PR overview

Open issues (1)

Uh oh!

This branch is waiting to be deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CLAassistant commented Sep 26, 2026 •

edited

Loading

greptile-apps Bot commented Sep 26, 2026 •

edited

Loading

codecov Bot commented Sep 27, 2026 •

edited

Loading