revert: "feat(usage): search team keys beyond the top-N in the Team usage view (#42857)" by yassin-berriai · Pull Request #43377 · BerriAI/litellm

yassin-berriai · 2026-09-26T23:46:55Z

Reverts #42857

TLDR

Problem this solves:

feat(usage): search team keys beyond the top-N in the Team usage view #42857 (server-side key search for the Team usage view) needs to come back out of main

How it solves it:

Plain git revert of the squash commit c2eb549, no conflicts
Removes the GET /team/daily/activity/aggregated/search route, its route registration, tests and the Team usage page wiring

User Flow

Before: on Usage > Team Usage, typing the alias of a key below the top 100 finds it through a server search

They open http://localhost:4000/ui/?page=team-usage, open Key Activity and type the alias
The dashboard calls GET http://localhost:4000/team/daily/activity/aggregated/search?search=...&team_ids=... and shows the key

After: the page behaves as it did before #42857

They open http://localhost:4000/ui/?page=team-usage, open Key Activity and type the alias
The search filters only the loaded top-N keys; GET http://localhost:4000/team/daily/activity/aggregated/search returns 404

Type

🧹 Refactoring

Caveats (if any)

Low

Stacked on the feat(proxy): server-side Team Usage export beyond the top-N key cap #42996 revert because both PRs edit the same team endpoint, schema and Team usage page files; GitHub retargets this PR to main once that one merges

🤖 Generated with Claude Code

CLAassistant · 2026-09-26T23:47:02Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

greptile-apps · 2026-09-26T23:49:43Z

Confidence Score: 3/5

[Medium risk] Removes a team usage search endpoint and related code.

The PR is not ready to merge because the removed route breaks existing clients and stale baseline entries fail CI

Findings

Existing clients lose search ▶
Stale baseline fails CI ▶
Surviving routes lose coverage ▶

Summary

This PR reverts server-side team-key search, including its proxy route, dashboard wiring, API types, and tests

The deleted route is incompatible with existing clients, and stale checker baseline entries will fail CI
A surviving role-and-route authorization assertion is lost with the removed test

_{Reviews (1) · Last reviewed commit: "Revert "feat(usage): search team keys be..."}

greptile-apps · 2026-09-26T23:49:46Z

@@ -6809,111 +6805,6 @@ async def get_team_daily_activity_aggregated(
    )


Existing clients lose search Removing this route makes existing clients that call /team/daily/activity/aggregated/search receive 404. The repository requires a user-controlled flag for backwards-incompatible changes

Rule Used: What: avoid backwards-incompatible changes without user-controlled flags Why: This breaks current behaviour for users using existing functionality Example of BAD: this PR (#22164) introduced run_post_custom... (source)

greptile-apps · 2026-09-26T23:49:46Z

@@ -6809,111 +6805,6 @@ async def get_team_daily_activity_aggregated(
    )


Stale baseline fails CI Deleting _team_key_search_where leaves six entries for it in unbounded_in_baseline.txt. The code-quality checker rejects entries without a matching finding, so its CI job fails

greptile-apps · 2026-09-26T23:49:46Z

-    assert outcome() == "allowed"
-
-
 @pytest.mark.parametrize(


Surviving routes lose coverage Deleting this test also removes its internal view-only access checks for both routes that remain. The repository requires test changes not to weaken regression coverage, so this check must be restored before merging

Rule Used: What: Flag any modifications to existing tests and verify they don't weaken test coverage or mask regressions. Why: Developers may alter tests to make failing code pass rather than fix the actual bug, hiding regressions. Good: ``` // Test updated t... (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

codecov · 2026-09-27T00:01:58Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

codspeed · 2026-09-28T19:56:30Z

Merging this PR will not alter performance

✅ 31 untouched benchmarks

_{Comparing litellm_revert_42857 (1903cec) with main (22cfc66)}

yuneng-berri · 2026-09-28T20:06:44Z

        ],
    )

-    signoz: CallbackOnUI = CallbackOnUI(


Please confirm if this is intentional. If not, please restore this

Not intentional, the revert dropped it. Restored in the single commit a12070b, the signoz block now matches main

…age view (#42857)"

…)" (#43378) * Revert "feat(usage): search keys beyond the top-N usage subset (#42827)" * revert: "feat(proxy): add LiteLLM_DailyGlobalSpend key-free rollup for the usage dashboard (#41324)" (#43595) * Revert "Merge pull request #41324 from BerriAI/litellm_daily_global_spend_table" * Revert "Merge pull request #41293 from BerriAI/litellm_usage_key_free_aggregate_split" (#43596) Co-authored-by: yassin <yassin@berri.ai> --------- Co-authored-by: yassin <yassin@berri.ai> Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> --------- Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>

veria-ai · 2026-09-28T21:45:18Z

        WHERE {where_clause}
        GROUP BY GROUPING SETS (
+            (date),
            (date, api_key),


Low: Unbounded key rollups

The per-key grouping sets no longer have the top-key limit. A user with many historical keys, or a team administrator on a large team, can repeatedly request aggregated usage and make the proxy fetch, enrich, and serialize six per-key rollups across the requested dates. Keep a bound on per-key results or paginate that breakdown while preserving complete totals.

veria-ai · 2026-09-28T21:45:26Z

PR overview

This PR reverts the Team usage view’s ability to search team keys beyond the top-N and changes how the proxy groups daily usage by key.

One issue remains open: per-key usage rollups are no longer bounded, so users with many historical keys or administrators of large teams can repeatedly trigger expensive aggregation and response serialization. The impact depends on the number of keys and the size of the requested date range. No issues have been addressed yet.

Open issues (1)

Low: Unbounded key rollups — litellm/proxy/management_endpoints/common_daily_activity.py:793

Fixed/addressed: 0 · PR risk: 4/10

yassin-berriai requested review from ryan-crabbe-berri and yuneng-berri as code owners September 26, 2026 23:46

yassin-berriai had a problem deploying to e2e-changed September 26, 2026 23:47 — with GitHub Actions Error

greptile-apps Bot reviewed Sep 26, 2026

View reviewed changes

devin-ai-integration Bot had a problem deploying to e2e-changed September 27, 2026 00:16 Error

Base automatically changed from litellm_revert_42996 to main September 28, 2026 19:33

yuneng-berri requested a review from a team September 28, 2026 19:33

devin-ai-integration Bot force-pushed the litellm_revert_42857 branch from 2b00ce9 to 0ac3f5b Compare September 28, 2026 19:41

devin-ai-integration Bot had a problem deploying to e2e-changed September 28, 2026 19:41 Error

yuneng-berri requested changes Sep 28, 2026

View reviewed changes

devin-ai-integration Bot had a problem deploying to e2e-changed September 28, 2026 20:34 Error

devin-ai-integration Bot force-pushed the litellm_revert_42857 branch from 4337d93 to 04633e2 Compare September 28, 2026 21:25

devin-ai-integration Bot requested review from kerry-berri and mateo-berri as code owners September 28, 2026 21:25

devin-ai-integration Bot had a problem deploying to e2e-changed September 28, 2026 21:25 Error

Revert "feat(usage): search team keys beyond the top-N in the Team us…

a12070b

…age view (#42857)"

devin-ai-integration Bot force-pushed the litellm_revert_42857 branch from 04633e2 to a12070b Compare September 28, 2026 21:27

devin-ai-integration Bot had a problem deploying to e2e-changed September 28, 2026 21:27 Error

devin-ai-integration Bot requested a review from yuneng-berri September 28, 2026 21:28

yuneng-berri requested a deployment to e2e-changed September 28, 2026 21:40 — with GitHub Actions Waiting

yuneng-berri approved these changes Sep 28, 2026

View reviewed changes

yuneng-berri enabled auto-merge (squash) September 28, 2026 21:42

veria-ai Bot reviewed Sep 28, 2026

View reviewed changes

yuneng-berri merged commit 7e383c9 into main Sep 28, 2026
94 of 96 checks passed

yuneng-berri deleted the litellm_revert_42857 branch September 28, 2026 21:47

mateo-berri mentioned this pull request Sep 29, 2026

feat(proxy): record in spend logs whether a request used a client-forwarded Anthropic OAuth token #43063

Merged

7 tasks done

Navigation Menu

Repository navigation

revert: "feat(usage): search team keys beyond the top-N in the Team usage view (#42857)" - #43377

revert: "feat(usage): search team keys beyond the top-N in the Team usage view (#42857)"#43377
yuneng-berri merged 2 commits into
mainfrom
litellm_revert_42857

yassin-berriai commented Sep 26, 2026

Uh oh!

CLAassistant commented Sep 26, 2026

Uh oh!

greptile-apps Bot commented Sep 26, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot Sep 26, 2026

Uh oh!

greptile-apps Bot Sep 26, 2026

Uh oh!

greptile-apps Bot Sep 26, 2026

Uh oh!

codecov Bot commented Sep 27, 2026

Uh oh!

codspeed Bot commented Sep 28, 2026 •

edited

Loading

Uh oh!

yuneng-berri Sep 28, 2026

Uh oh!

devin-ai-integration Bot Sep 28, 2026

Uh oh!

veria-ai Bot Sep 28, 2026

Uh oh!

veria-ai Bot commented Sep 28, 2026

Uh oh!

Uh oh!

This branch is waiting to be deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -6809,111 +6805,6 @@ async def get_team_daily_activity_aggregated(
		)

Conversation

yassin-berriai commented Sep 26, 2026

TLDR

User Flow

Type

Caveats (if any)

Low

Uh oh!

CLAassistant commented Sep 26, 2026

Uh oh!

greptile-apps Bot commented Sep 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 3/5

Findings

Summary

Uh oh!

greptile-apps Bot Sep 26, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Sep 26, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Sep 26, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Sep 27, 2026

Codecov Report

Uh oh!

codspeed Bot commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Uh oh!

yuneng-berri Sep 28, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Sep 28, 2026

Choose a reason for hiding this comment

Uh oh!

veria-ai Bot Sep 28, 2026

Choose a reason for hiding this comment

Uh oh!

veria-ai Bot commented Sep 28, 2026

PR overview

Open issues (1)

Uh oh!

Uh oh!

This branch is waiting to be deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

greptile-apps Bot commented Sep 26, 2026 •

edited

Loading

codspeed Bot commented Sep 28, 2026 •

edited

Loading