Skip to content

fix(ui): use imported lucide icons in skill detail copy button - #38109

Open
devin-ai-integration[bot] wants to merge 1 commit into
litellm_internal_stagingfrom
litellm_ui_skill_detail_icon_imports
Open

fix(ui): use imported lucide icons in skill detail copy button#38109
devin-ai-integration[bot] wants to merge 1 commit into
litellm_internal_stagingfrom
litellm_ui_skill_detail_icon_imports

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

TLDR

Problem this solves:

  • build-ui CI fails on litellm_internal_staging for every PR
  • Skill detail page references undefined CheckOutlined / CopyOutlined icons

How it solves it:

  • Use the already-imported lucide Check / Copy icons, matching the other copy buttons in this file

User Flow

Before: a contributor's unrelated PR goes red because the dashboard build fails on the base branch

  1. They push any PR targeting litellm_internal_staging
  2. The build-ui check fails with Type error: Cannot find name 'CheckOutlined' in the skills detail component
  3. Their PR cannot go green regardless of its own changes

After: the dashboard builds and the copy button on the skill detail page works

  1. They push any PR targeting litellm_internal_staging
  2. The build-ui check compiles the dashboard successfully
  3. On the skills page detail view, the marketplace command copy button shows the copy icon and flips to a check icon after clicking, like the other copy buttons on the page

Relevant issues

Linear ticket

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have added meaningful tests (no test needed: build-breaking type error, caught by the build-ui CI check itself)
  • The handful of test files covering my change pass locally, e.g. uv run pytest tests/test_litellm/<your_test_file>.py -v (n/a: UI-only change; npm run build passes locally)
  • My PR passes all required CI/CD checks (e.g., lint, schema.d.ts sync check, etc.)
  • My PR's scope is as isolated as possible; it only solves 1 specific problem
  • I have received a Greptile Confidence Score of at least 4/5 before requesting a maintainer review (Greptile reviews automatically once the PR is opened; only comment @greptileai to re-request a review after pushing changes)

Screenshots / Proof of Fix

Before (base litellm_internal_staging)

Dashboard production build

  1. cd ui/litellm-dashboard && npm run build
  2. Observed output:
./src/components/claude_code_plugins/skill_detail.tsx:346:53
Type error: Cannot find name 'CheckOutlined'.

After (this PR tip)

Dashboard production build

  1. cd ui/litellm-dashboard && npm run build
  2. Observed output:
✓ Compiled successfully in 8.0s
✓ Generating static pages using 7 workers (51/51)

Type

🐛 Bug Fix

Caveats (if any)

Final Attestation

  • The tests check the right things, including the edge cases, and regressions in the respective real-world customer use-cases are not possible after this PR

Link to Devin session: https://app.devin.ai/sessions/e97eb796504147258f46ce84ea43d373

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@greptile-apps

greptile-apps Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes the skill detail marketplace copy button by replacing undefined Ant Design icon references with the already-imported Lucide icons.

  • Uses Check and Copy consistently with the other copy buttons in the component.
  • Applies the established size-3 icon sizing.
  • Resolves the unresolved identifiers that prevented the dashboard TypeScript build.

Confidence Score: 5/5

The PR appears safe to merge; the isolated icon replacement fixes the dashboard build error and preserves established copy-button behavior.

The replacement icons are already imported, accept the supplied styling, and use the same copied-state rendering pattern as the component’s other copy buttons.

Important Files Changed

Filename Overview
ui/litellm-dashboard/src/components/claude_code_plugins/skill_detail.tsx Correctly replaces two undefined icon components with imported Lucide equivalents matching sibling copy buttons; no issues found.

Reviews (1): Last reviewed commit: "fix(ui): use imported lucide icons in sk..." | Re-trigger Greptile

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

All required checks pass. The one failing check, code-quality, is a preexisting base-branch issue (unit shard job timeouts) fixed separately in #38105; it is not caused by this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant