fix(ui): use imported lucide icons in skill detail copy button - #38109
fix(ui): use imported lucide icons in skill detail copy button#38109devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Greptile SummaryThis PR fixes the skill detail marketplace copy button by replacing undefined Ant Design icon references with the already-imported Lucide icons.
Confidence Score: 5/5The PR appears safe to merge; the isolated icon replacement fixes the dashboard build error and preserves established copy-button behavior. The replacement icons are already imported, accept the supplied styling, and use the same copied-state rendering pattern as the component’s other copy buttons.
|
| Filename | Overview |
|---|---|
| ui/litellm-dashboard/src/components/claude_code_plugins/skill_detail.tsx | Correctly replaces two undefined icon components with imported Lucide equivalents matching sibling copy buttons; no issues found. |
Reviews (1): Last reviewed commit: "fix(ui): use imported lucide icons in sk..." | Re-trigger Greptile
|
All required checks pass. The one failing check, code-quality, is a preexisting base-branch issue (unit shard job timeouts) fixed separately in #38105; it is not caused by this PR. |
TLDR
Problem this solves:
build-uiCI fails on litellm_internal_staging for every PRCheckOutlined/CopyOutlinediconsHow it solves it:
Check/Copyicons, matching the other copy buttons in this fileUser Flow
Before: a contributor's unrelated PR goes red because the dashboard build fails on the base branch
build-uicheck fails withType error: Cannot find name 'CheckOutlined'in the skills detail componentAfter: the dashboard builds and the copy button on the skill detail page works
build-uicheck compiles the dashboard successfullyRelevant issues
Linear ticket
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
build-uiCI check itself)uv run pytest tests/test_litellm/<your_test_file>.py -v(n/a: UI-only change;npm run buildpasses locally)@greptileaito re-request a review after pushing changes)Screenshots / Proof of Fix
Before (base litellm_internal_staging)
Dashboard production build
cd ui/litellm-dashboard && npm run buildAfter (this PR tip)
Dashboard production build
cd ui/litellm-dashboard && npm run buildType
🐛 Bug Fix
Caveats (if any)
Final Attestation
Link to Devin session: https://app.devin.ai/sessions/e97eb796504147258f46ce84ea43d373