fix(ci): raise unit shard job timeouts to satisfy startup-safety guard - #38105
fix(ci): raise unit shard job timeouts to satisfy startup-safety guard#38105devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Greptile SummaryThis PR raises the job timeout from 55 to 60 minutes for three unit-test shards, matching the reusable workflow’s startup-safety requirement.
Confidence Score: 5/5The PR appears safe to merge, with the targeted timeout changes correctly satisfying the existing workflow startup invariant. Each affected shard retains a 20-minute test budget and now receives the required 60-minute job deadline, accounting for the reusable workflow’s 35-minute setup ceiling and 5-minute runner overhead.
|
| Filename | Overview |
|---|---|
| .github/workflows/test-unit.yml | The three timeout increases are correctly consumed as job-level deadlines and exactly satisfy the existing 60-minute startup-safety minimum. |
Reviews (1): Last reviewed commit: "fix(ci): raise unit shard job timeouts t..." | Re-trigger Greptile
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
TLDR
Problem this solves:
How it solves it:
User Flow
Before: any contributor opening a PR against litellm_internal_staging sees code-quality fail on unrelated changes
unitgives pytest 20m but caps the job at 55m ... raise job-timeout-minutes to at least 60" three timesAfter: the same PR passes code-quality
Relevant issues
The guard
tests/code_coverage_tests/check_workflow_startup_safety.pyfails on the current base branch tip (ddf4c8e): the three shards added withjob-timeout-minutes: 55violate its 60m minimum. First observed as the code-quality failure on #37917, which does not touch any workflow fileLinear ticket
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
uv run pytest tests/test_litellm/<your_test_file>.py -v. Leave the suites (make test-unit-*,make test-unit) to CI: it finishes in ~15 minutes where a laptop takes an hour or more@greptileaito re-request a review after pushing changes)Delays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
Screenshots / Proof of Fix
This is a CI-only change; the guard itself is the end-user surface, so the proof is running it exactly as the code-quality job does
Before (ddf4c8e)
uv run --no-sync python ./tests/code_coverage_tests/check_workflow_startup_safety.pyAfter (104f928)
uv run --no-sync python ./tests/code_coverage_tests/check_workflow_startup_safety.pyType
🐛 Bug Fix
Caveats (if any)
Final Attestation
Link to Devin session: https://app.devin.ai/sessions/e97eb796504147258f46ce84ea43d373