Skip to content

docs(team): document mcp_rpm_limit in update_team docstring - #33475

Closed
Bartok9 wants to merge 2 commits into
BerriAI:litellm_oss_daily_2026_07_15from
Bartok9:docs-update-team-mcp-rpm-limit
Closed

docs(team): document mcp_rpm_limit in update_team docstring#33475
Bartok9 wants to merge 2 commits into
BerriAI:litellm_oss_daily_2026_07_15from
Bartok9:docs-update-team-mcp-rpm-limit

Conversation

@Bartok9

@Bartok9 Bartok9 commented Jul 15, 2026

Copy link
Copy Markdown

Summary

  • Add the missing mcp_rpm_limit parameter line to the update_team endpoint docstring so it matches UpdateTeamRequest and the existing new_team docs.
  • Unblocks documentation / code-quality (documentation_test_api_docs) which currently fail on every PR against litellm_oss_daily_2026_07_15 with:
    Missing documentation for parameters: mcp_rpm_limit.

Context

Pre-Submission checklist

  • I have added meaningful tests (N/A — docstring parity; validated locally that UpdateTeamRequest fields − docstring params = ∅)
  • My PR passes all CI/CD checks (e.g., lint, format, unit tests)
  • My PR's scope is as isolated as possible; it only solves 1 specific problem
  • Greptile confidence (awaiting)

Test plan

  • Local AST check: no missing pydantic params in update_team docstring
  • CI documentation + code-quality green for documentation_test_api_docs

UpdateTeamRequest already exposes mcp_rpm_limit and new_team documents it,
but update_team's docstring omitted the field. documentation_test_api_docs
and code-quality fail on every PR against litellm_oss_daily_2026_07_15 with
"Missing documentation for parameters: mcp_rpm_limit".

Mirrors the approach in closed BerriAI#33420 (which fixed litellm_internal_staging
only). One-line docstring fix; no behavior change.
@greptile-apps

greptile-apps Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds a single missing mcp_rpm_limit parameter line to the update_team endpoint's docstring so it matches the existing UpdateTeamRequest Pydantic model and the new_team endpoint docs, resolving a CI documentation_test_api_docs failure. No runtime behavior is changed.

  • Adds - mcp_rpm_limit: Optional[Dict[str, int]] - ... to the update_team docstring at team_endpoints.py:1624, directly after the existing model_tpm_limit line.
  • The description, type signature, and example values are consistent with how the field is defined on UpdateTeamRequest and documented on new_team.

Confidence Score: 5/5

Single-line docstring addition with no runtime effect; safe to merge.

The change is a one-line docstring addition that adds the previously missing mcp_rpm_limit parameter description to update_team. It restores parity with UpdateTeamRequest and fixes a CI documentation check with no code path changes.

No files require special attention.

Important Files Changed

Filename Overview
litellm/proxy/management_endpoints/team_endpoints.py Adds one missing mcp_rpm_limit parameter line to the update_team docstring to match UpdateTeamRequest and the new_team docs; no logic changes.

Reviews (1): Last reviewed commit: "docs(team): document mcp_rpm_limit in up..." | Re-trigger Greptile

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Keeps dashboard OpenAPI types in sync after documenting update_team mcp_rpm_limit.
@Bartok9

Bartok9 commented Jul 17, 2026

Copy link
Copy Markdown
Author

Superseded: current main already documents mcp_rpm_limit on update_team (and matching OpenAPI TS comments in the regenerated schema path). Closing this docs-only PR as no-op vs tip of main so we do not leave a forever-behind branch. Happy to reopen if anything regressed.

@Bartok9

Bartok9 commented Jul 17, 2026

Copy link
Copy Markdown
Author

closed: docs already on main

@Bartok9 Bartok9 closed this Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant