Skip to content

docs(team): document mcp_rpm_limit in update_team docstring - #33420

Closed
yucheng-berri wants to merge 2 commits into
litellm_internal_stagingfrom
litellm_update_team_docstring_mcp_rpm_limit
Closed

docs(team): document mcp_rpm_limit in update_team docstring#33420
yucheng-berri wants to merge 2 commits into
litellm_internal_stagingfrom
litellm_update_team_docstring_mcp_rpm_limit

Conversation

@yucheng-berri

Copy link
Copy Markdown
Contributor

Relevant issues

Linear ticket

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have added meaningful tests
  • My PR passes all CI/CD checks (e.g., lint, format, unit tests)
  • My PR's scope is as isolated as possible; it only solves 1 specific problem
  • I have received a Greptile Confidence Score of at least 4/5 before requesting a maintainer review (Greptile reviews automatically once the PR is opened; only comment @greptileai to re-request a review after pushing changes)

Screenshots / Proof of Fix

The documentation CI check currently fails on every PR off litellm_internal_staging because tests/documentation_tests/test_api_docs.py requires each UpdateTeamRequest field to appear in the update_team docstring and mcp_rpm_limit was documented for new_team but never added to update_team. Example failure on an unrelated PR: https://github.com/BerriAI/litellm/actions/runs/29440196589/job/87436858516

At this commit the validator passes locally:

python ./tests/documentation_tests/test_api_docs.py; echo exit=$?
exit=0

No runtime behavior is touched; the change is one docstring line

Type

Documentation

Changes

Adds the mcp_rpm_limit parameter line to the update_team endpoint docstring, copied from the new_team docstring where the field is already documented

Behavior changes

None; docstring only

@greptile-apps

greptile-apps Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes a documentation CI failure by adding a missing mcp_rpm_limit parameter line to the update_team endpoint docstring, mirroring the entry already present in the new_team docstring. The generated TypeScript schema file is updated to match.

  • Adds one docstring line for mcp_rpm_limit to update_team in team_endpoints.py, unblocking the test_api_docs.py documentation validator that requires every UpdateTeamRequest field to appear in the docstring.
  • Mirrors the same line in the auto-generated schema.d.ts; no runtime behavior is changed.

Confidence Score: 5/5

Safe to merge — the change is a single docstring line addition with no effect on runtime behaviour.

Both changed files receive only the addition of one documentation line. No logic, schema migrations, auth paths, or tests are touched; the TypeScript schema file is generated and mirrors the Python docstring directly. The change resolves a failing documentation CI validator with no risk of regression.

No files require special attention.

Important Files Changed

Filename Overview
litellm/proxy/management_endpoints/team_endpoints.py Adds the missing mcp_rpm_limit parameter line to the update_team docstring to satisfy the documentation validator test; no logic changes.
ui/litellm-dashboard/src/lib/http/schema.d.ts Auto-generated TypeScript schema file updated to mirror the same mcp_rpm_limit docstring addition; no functional change.

Reviews (2): Last reviewed commit: "chore(ui): regenerate dashboard API type..." | Re-trigger Greptile

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@codspeed-hq

codspeed-hq Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 31 untouched benchmarks


Comparing litellm_update_team_docstring_mcp_rpm_limit (c923f04) with litellm_internal_staging (5d25e75)1

Open in CodSpeed

Footnotes

  1. No successful run was found on litellm_internal_staging (ab38468) during the generation of this report, so 49b6f1e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@yucheng-berri

Copy link
Copy Markdown
Contributor Author

@greptileai

@yucheng-berri

Copy link
Copy Markdown
Contributor Author

Superseded: litellm_internal_staging now documents mcp_rpm_limit in the update_team docstring, so the documentation check is fixed at the source

@yucheng-berri
yucheng-berri deleted the litellm_update_team_docstring_mcp_rpm_limit branch July 19, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant