fix(ci): authenticate git push in create_daily_oss_agent_shin_branch workflow - #29824
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(ci): authenticate git push in create_daily_oss_agent_shin_branch workflow#29824cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
The workflow added in #28829 (commit 48dd71b) uses persist-credentials: false on actions/checkout but still runs 'git push origin', so the push fails with 'fatal: could not read Username for https://github.com'. Push via an authenticated URL using GITHUB_TOKEN, mirroring the fix proposed in #28440 for create_daily_staging_branch.yml. Co-authored-by: Krrish Dholakia <krrish-berri-2@users.noreply.github.com>
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issues
CI failure on the scheduled
Create Daily oss-agent-shin Branchworkflow (run 27048098052). Sister PR #28440 already fixes the same class of bug forcreate_daily_staging_branch.ymland is still open; this PR fixes the equivalent bug in the newercreate_daily_oss_agent_shin_branch.ymlworkflow that was added in #28829.Changes
The
create_daily_oss_agent_shin_branch.ymlworkflow added in #28829 usespersist-credentials: falseonactions/checkout(matching the zizmor-recommended pattern fromdfb543369b) but still runsgit push origin $BRANCH_NAME. With credentials no longer persisted into the local git config, the push fails with:Fix: push via an authenticated URL that uses
$GITHUB_TOKEN(already exported in the job env), keeping the zizmor-recommendedpersist-credentials: falsesetting intact. This mirrors the fix proposed in #28440 for the staging branch workflow.Type
🐛 Bug Fix
🚄 Infrastructure
Screenshots / Proof of Fix
The change cannot be exercised without merging because the failing job is a scheduled workflow that needs
secrets.GITHUB_TOKENfrom a default branch run. Reviewers can verify by reading the diff against the existing fix in #28440, or by manually triggering theCreate Daily oss-agent-shin Branchworkflow from the Actions tab after merge and confirming the new branch is created.