fix(ci): authenticate git push in create_daily_staging_branch workflow - #28440
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(ci): authenticate git push in create_daily_staging_branch workflow#28440cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
After dfb5433 added persist-credentials: false to actions/checkout (addressing zizmor comments), the subsequent 'git push origin' commands failed with 'fatal: could not read Username for https://github.com' because no credential helper was configured. Push via an explicit authenticated URL using GITHUB_TOKEN so both the create-staging-branch and create-internal-dev-branch jobs work again. Co-authored-by: Krrish Dholakia <krrish-berri-2@users.noreply.github.com>
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issues
CI failure on the scheduled
Create Daily Staging Branchworkflow.Changes
Commit
dfb543369b("fix: address zizmor comments") addedpersist-credentials: falseto theactions/checkoutstep but kept the existinggit push origin $BRANCH_NAMEcommands. With credentials no longer persisted into the local git config, the push fails with:This affects both jobs in the workflow (
create-staging-branchandcreate-internal-dev-branch) — see the failing run 26199401856.Fix: push via an authenticated URL that uses
$GITHUB_TOKEN(already exported in the job env), keeping the zizmor-recommendedpersist-credentials: falsesetting intact.Type
🐛 Bug Fix
🚄 Infrastructure