fix(mypy): fix type: ignore placement for OTEL LogRecord import

[jquinter]

Summary

• Fix mypy attr-defined error on opentelemetry.py:1013 caused by # type: ignore being placed on the wrong line in a multi-line import
• Collapse multi-line imports to single-line so # type: ignore[attr-defined] is on the from line where mypy reports the error
• Add no-redef to the fallback except ImportError branch since SdkLogRecord is already defined in the try branch

Type

🐛 Bug Fix

Test plan

• cd litellm && poetry run mypy . passes with 0 errors (1657 source files)

Changes

• No functional change — only type-ignore comment placement

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
litellm	Error		Feb 3, 2026 5:34pm

[greptile-apps]

Greptile Overview

Greptile Summary

Fixed mypy type checking errors by correcting the placement of # type: ignore comments in the OpenTelemetry integration.

Changes:

• Collapsed multi-line imports to single-line format for both the try and except branches of LogRecord import
• Moved # type: ignore[attr-defined] to the from line (1007) where mypy actually reports the error
• Added no-redef suppression to the fallback import (1009) since SdkLogRecord is defined in both branches

Impact:

• No functional changes to runtime behavior
• Resolves mypy attr-defined errors that were previously reported on line 1013
• Improves type checking accuracy for both OTEL SDK versions (< 1.39.0 and >= 1.39.0)

Confidence Score: 5/5

• This PR is safe to merge with no risk
• Only affects type checking comments with no runtime changes; fixes legitimate mypy errors by following best practices for type ignore placement on single-line imports
• No files require special attention

Important Files Changed

Filename	Overview
litellm/integrations/opentelemetry.py	Collapsed multi-line imports to single-line and moved mypy type ignore comments to correct position; added no-redef suppression for fallback import

Sequence Diagram

sequenceDiagram
    participant MyPy as MyPy Type Checker
    participant Code as opentelemetry.py
    participant OTEL as OpenTelemetry SDK
    
    Note over MyPy,Code: Before Fix (Multi-line import)
    MyPy->>Code: Check import on line 1007-1009
    Code->>OTEL: Try: from opentelemetry.sdk._logs<br/>import LogRecord as SdkLogRecord
    Note over MyPy: type: ignore on wrong line (1008)<br/>Reports attr-defined error on line 1013
    
    Note over MyPy,Code: After Fix (Single-line import)
    MyPy->>Code: Check import on line 1007
    Code->>OTEL: Try: from opentelemetry.sdk._logs<br/>import LogRecord as SdkLogRecord
    Note over Code: type: ignore[attr-defined] on same line (1007)
    MyPy->>Code: Suppresses attr-defined error
    
    alt Import Fails (OTEL >= 1.39.0)
        Code->>OTEL: Except: from opentelemetry.sdk._logs._internal<br/>import LogRecord as SdkLogRecord
        Note over Code: type: ignore[attr-defined, no-redef] on line 1009
        MyPy->>Code: Suppresses attr-defined and no-redef errors
    end

Loading

[greptile-apps]

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}