Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(symfony5): support Symfony5 and restore travis ci #66

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Conversation

Oliboy50
Copy link
Member

@Oliboy50 Oliboy50 commented Dec 3, 2019

Why?

  • we say in composer.json that we support >php7.0 but our bundle contains code only compatible with >php7.1 (nullable typing)... so we already dropped support for php7.0 💃
  • our CI is failing for a while now... because it has been deactivated somehow 🤷‍♂
  • we depend on LegacyEventProxy which is a Symfony @internal class... and has been brutally removed in Symfony 5

How?

  • supports php7.1 to php7.3 in our CI (php7.4 may work fine but atoum is not compatible with it yet... so we can't test it well)
  • enable support for Symfony 5 (we didn't test it in a real symfony5 project yet... but at least our tests passes 🤷‍♂) (see REAL TESTING section)
  • drop support for the old EventDispatcherInterface::dispatch param orders
  • drop support for unsupported symfony version https://symfony.com/releases
  • drop support for symfony/config < 4.3 (because we use the new TreeBuilder::getRootNode() function which came with 4.2... but since 4.2 is not a supported version, we support only 4.3)

=> of course this will be a major update -> v3.0.0

REAL TESTING

I made a simple project to make sure the project does not throw any exception nor deprecation using Symfony5 => https://github.com/Oliboy50/sf5-testing

Capture d’écran 2019-12-09 à 17 51 17

Capture d’écran 2019-12-09 à 17 57 43

@Oliboy50 Oliboy50 force-pushed the chore/ci branch 3 times, most recently from c42a9a1 to f40a03b Compare December 3, 2019 09:50
src/M6WebGuzzleHttpBundle.php Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants