Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove coke, use cs-fixer and add a makefile #65

Merged
merged 9 commits into from
Dec 18, 2019

Conversation

GautierLB
Copy link
Contributor

Why

  • Coke is quite old and best practices have changed
  • A makefile is always useful

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
tests/Units/Middleware/EventDispatcherMiddlewareTest.php Outdated Show resolved Hide resolved
@Oliboy50
Copy link
Member

Oliboy50 commented Dec 10, 2019

@GautierLB #66 has been merged

could you rebase and make sure travis is now able to use the make ci target as expected 🙏 ?

(note: you may have to close/open this PR to trigger travis for it)

@GautierLB
Copy link
Contributor Author

It almost worked as expected ! but it does now 👍
Waiting for another approve to merge this 🙂

Copy link
Member

@Oliboy50 Oliboy50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ❤️
just 2 small things and we're good 🙆‍♂

.travis.yml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Member

@Oliboy50 Oliboy50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@GautierLB GautierLB merged commit 1da320f into master Dec 18, 2019
@Benoit382 Benoit382 deleted the refresh-project-quality-tool branch April 14, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants