Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mkdocs icons #188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BrunoB81HK
Copy link

@BrunoB81HK BrunoB81HK commented Jan 3, 2024

Add icons for mkdocs. I used the icon for mkdocs-material since I can't find any for mkdocs.

@BrunoB81HK BrunoB81HK marked this pull request as ready for review January 3, 2024 03:13
@BrunoB81HK
Copy link
Author

@BeardedBear Any update on this?

@BeardedBear
Copy link
Owner

Same comment as here : #187 (comment)

But I'd like to add that in this particular case, the dimensions don't respect the 1:1 ratio, and black icons pose problems when switching between dark and light themes, which is why I use a special gray for monochrome icons ;)

@BrunoB81HK
Copy link
Author

Hey! Yes, that is a good point!

What color are you using and also, how would you solve the 1:1 ratio issue?

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants