Add pre-commit icons Fixes #186 #187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BeardedBear Any updates on this? |
|
Hey! first of all, thanks for taking the time to make a PR! However, in order to keep a visual coherence with the whole pack, the proposed icon doesn't quite fit with the others, but it's not so much your fault, I'm going to create a small documentation to know what criteria I have to respect when icons are proposed (border size, internal transparency management etc). |
|
Hey! Thanks for the reply! I agree that it should be updated to reflect the desired style. After all, the design and visual coherence is the main reason why I use your icon pack 😄 Let me know how if I can help with anything! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pre-commit sets of icons