Skip to content

Test updated gtk3 vcpkg port #6816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AenBleidd wants to merge 4 commits into from
Closed

Test updated gtk3 vcpkg port #6816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08c8ab5
Test updated gtk3 vcpkg port
AenBleidd Jan 26, 2026
c88e329
Try to fix configuration
AenBleidd Jan 26, 2026
417ab64
Another try
AenBleidd Jan 26, 2026
f2f5ac9
Revert
AenBleidd Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions 3rdParty/vcpkg_ports/configs/manager/linux/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@
"features": ["ssl3", "weak-ssl-ciphers"],
"default-features": false
},
{
"name": "gtk3",
"default-features": false
Comment on lines +16 to +17
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation is inconsistent with the rest of the file. The gtk3 dependency uses 4 spaces for the opening brace, while other dependencies in the file (curl, openssl, wxwidgets, gdk-pixbuf, libzip) use 2 spaces. For consistency with the existing code style, the gtk3 entry should use 2 spaces of indentation like the other dependencies.

Suggested change
"name": "gtk3",
"default-features": false
"name": "gtk3",
"default-features": false

Copilot uses AI. Check for mistakes.
},
Comment thread
AenBleidd marked this conversation as resolved.
{
"name": "wxwidgets",
"default-features": false
Expand Down
6 changes: 5 additions & 1 deletion 3rdParty/vcpkg_ports/ports/gtk3/portfile.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,11 @@ else()
list(APPEND OPTIONS_RELEASE -Dintrospection=false)
endif()

list(APPEND OPTIONS -Dwayland_backend=false)
if("wayland" IN_LIST FEATURES)
list(APPEND OPTIONS -Dwayland_backend=true)
else()
list(APPEND OPTIONS -Dwayland_backend=false)
endif()

vcpkg_configure_meson(
SOURCE_PATH "${SOURCE_PATH}"
Expand Down
16 changes: 15 additions & 1 deletion 3rdParty/vcpkg_ports/ports/gtk3/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "gtk3",
"version": "3.24.51",
"port-version": 1,
"port-version": 2,
"description": "Portable library for creating graphical user interfaces.",
"homepage": "https://www.gtk.org/",
"license": null,
Expand Down Expand Up @@ -55,6 +55,12 @@
"host": true
}
],
"default-features": [
{
"name": "wayland",
"platform": "linux | freebsd | openbsd"
}
],
"features": {
"introspection": {
"description": "Build with introspection",
Expand Down Expand Up @@ -83,6 +89,14 @@
]
}
]
},
"wayland": {
"description": "Build with Wayland support",
"supports": "linux | freebsd | openbsd",
"dependencies": [
"wayland",
"wayland-protocols"
]
}
}
}
Loading