Skip to content

Test updated gtk3 vcpkg port#6816

Closed
AenBleidd wants to merge 4 commits into
masterfrom
vko_test_fixed_gtk3
Closed

Test updated gtk3 vcpkg port#6816
AenBleidd wants to merge 4 commits into
masterfrom
vko_test_fixed_gtk3

Conversation

@AenBleidd
Copy link
Copy Markdown
Member

@AenBleidd AenBleidd commented Jan 26, 2026

Summary by cubic

Adds an optional Wayland feature to the gtk3 vcpkg port and makes the build toggle Wayland backend based on that feature. The manager now depends on gtk3 with default features off to avoid pulling Wayland by default; port-version bumped to 2.

  • New Features
    • Added "wayland" feature to gtk3 with wayland and wayland-protocols dependencies; enabled by default on Linux/BSD.
    • Updated portfile to set wayland_backend=true only when the "wayland" feature is enabled.
    • Manager linux vcpkg.json now includes gtk3 with "default-features": false.

Written for commit f2f5ac9. Summary will update on new commits.

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
Copilot AI review requested due to automatic review settings January 26, 2026 18:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the GTK3 vcpkg port to add optional Wayland backend support, making it available as a platform-conditional default feature while explicitly disabling it for the BOINC manager on Linux.

Changes:

  • Added Wayland as a configurable feature with platform-specific support for Linux, FreeBSD, and OpenBSD
  • Made Wayland a default feature for supported platforms in the GTK3 port definition
  • Explicitly disabled default features for GTK3 in the Linux manager configuration to opt out of Wayland support

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
3rdParty/vcpkg_ports/ports/gtk3/vcpkg.json Incremented port version, added Wayland as a platform-conditional default feature with required dependencies
3rdParty/vcpkg_ports/ports/gtk3/portfile.cmake Added conditional logic to enable/disable Wayland backend based on feature selection
3rdParty/vcpkg_ports/configs/manager/linux/vcpkg.json Explicitly disabled GTK3 default features to opt out of Wayland support for the manager

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
Copilot AI review requested due to automatic review settings January 26, 2026 18:47
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread 3rdParty/vcpkg_ports/configs/manager/linux/vcpkg.json
Comment on lines +16 to +17
"name": "gtk3",
"default-features": false
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation is inconsistent with the rest of the file. The gtk3 dependency uses 4 spaces for the opening brace, while other dependencies in the file (curl, openssl, wxwidgets, gdk-pixbuf, libzip) use 2 spaces. For consistency with the existing code style, the gtk3 entry should use 2 spaces of indentation like the other dependencies.

Suggested change
"name": "gtk3",
"default-features": false
"name": "gtk3",
"default-features": false

Copilot uses AI. Check for mistakes.
@AenBleidd AenBleidd closed this Feb 6, 2026
@AenBleidd AenBleidd deleted the vko_test_fixed_gtk3 branch February 6, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants