Test updated gtk3 vcpkg port#6816
Conversation
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
There was a problem hiding this comment.
Pull request overview
This pull request updates the GTK3 vcpkg port to add optional Wayland backend support, making it available as a platform-conditional default feature while explicitly disabling it for the BOINC manager on Linux.
Changes:
- Added Wayland as a configurable feature with platform-specific support for Linux, FreeBSD, and OpenBSD
- Made Wayland a default feature for supported platforms in the GTK3 port definition
- Explicitly disabled default features for GTK3 in the Linux manager configuration to opt out of Wayland support
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| 3rdParty/vcpkg_ports/ports/gtk3/vcpkg.json | Incremented port version, added Wayland as a platform-conditional default feature with required dependencies |
| 3rdParty/vcpkg_ports/ports/gtk3/portfile.cmake | Added conditional logic to enable/disable Wayland backend based on feature selection |
| 3rdParty/vcpkg_ports/configs/manager/linux/vcpkg.json | Explicitly disabled GTK3 default features to opt out of Wayland support for the manager |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "name": "gtk3", | ||
| "default-features": false |
There was a problem hiding this comment.
The indentation is inconsistent with the rest of the file. The gtk3 dependency uses 4 spaces for the opening brace, while other dependencies in the file (curl, openssl, wxwidgets, gdk-pixbuf, libzip) use 2 spaces. For consistency with the existing code style, the gtk3 entry should use 2 spaces of indentation like the other dependencies.
| "name": "gtk3", | |
| "default-features": false | |
| "name": "gtk3", | |
| "default-features": false |
Summary by cubic
Adds an optional Wayland feature to the gtk3 vcpkg port and makes the build toggle Wayland backend based on that feature. The manager now depends on gtk3 with default features off to avoid pulling Wayland by default; port-version bumped to 2.
Written for commit f2f5ac9. Summary will update on new commits.