Particle Enums: Use Consistently and Rename - #351
Merged
Merged
Conversation
ax3l
force-pushed
the
topic-rename-AoS
branch
5 times, most recently
from
April 25, 2023 22:14
f4237f7 to
7a97555
Compare
- rename: `m_qm` to `qm` because it is charge over mass, not its inverse - rename AoS to use s-based description by default: `z`->`t` - Rename `AddNParticles` parameter, since we add particles for fixed `s` - Use enums consistently whe we access `.pos` arguments, instead of `0-2`
cemitch99
reviewed
Apr 27, 2023
cemitch99
reviewed
Apr 27, 2023
cemitch99
reviewed
Apr 27, 2023
cemitch99
reviewed
Apr 27, 2023
cemitch99
reviewed
Apr 27, 2023
cemitch99
reviewed
Apr 27, 2023
cemitch99
reviewed
Apr 27, 2023
cemitch99
reviewed
Apr 27, 2023
cemitch99
reviewed
Apr 27, 2023
cemitch99
reviewed
Apr 27, 2023
cemitch99
reviewed
Apr 27, 2023
cemitch99
reviewed
Apr 27, 2023
cemitch99
left a comment
cemitch99
left a comment
Member
There was a problem hiding this comment.
Added mostly comments about the appearance of pz vs pt.
ax3l
commented
Apr 27, 2023
Co-authored-by: Chad Mitchell <46825199+cemitch99@users.noreply.github.com>
ax3l
commented
Apr 27, 2023
cemitch99
reviewed
Apr 27, 2023
cemitch99
reviewed
Apr 27, 2023
cemitch99
reviewed
Apr 27, 2023
cemitch99
reviewed
Apr 27, 2023
Member
Author
|
@cemitch99 I found a way to define alias for |
Mention s-based interpretation first, because its the most commonly used throughout the code base.
cemitch99
reviewed
Apr 27, 2023
cemitch99
approved these changes
Apr 27, 2023
cemitch99
left a comment
cemitch99
left a comment
Member
There was a problem hiding this comment.
Ok, looks good to me. Thanks!
ax3l
commented
May 2, 2023
Comment on lines
+68
to
+69
| ux, ///< momentum in x, scaled by the magnitude of the reference momentum [unitless] (at fixed s or t) | ||
| uy, ///< momentum in y, scaled by the magnitude of the reference momentum [unitless] (at fixed s or t) |
Member
Author
There was a problem hiding this comment.
Follow-up: let's call those px and py, too.
ax3l
commented
May 2, 2023
| z, ///< position in z [m] (at fixed t) OR time-of-flight ct [m] (at fixed s) | ||
| x, ///< position in x [m] (at fixed s OR fixed t) | ||
| y, ///< position in y [m] (at fixed s OR fixed t) | ||
| t, ///< time-of-flight c*t [m] (at fixed s) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
m_qmtoqmbecause it is charge over mass, not its inversez->tAddNParticlesparameter, since we add particles for fixeds.posarguments, instead of0-2