Conversation
Merged
cemitch99
reviewed
Apr 25, 2023
cemitch99
left a comment
cemitch99
left a comment
Member
There was a problem hiding this comment.
This must have been tedious, but I'm not sure it is necessary. This notation is equivalent to specifying the units for "t", which should be done anyway in the documentation. (Likewise, the units of px, etc. are not apparent without visiting the documentation.)
Member
Author
|
Both is fine, I used the I would still make particle |
Rename for consistency with the same attribute on particles and to reflect its dimensionality of a length.
ax3l
force-pushed
the
topic-rename-refpart-ct
branch
from
April 25, 2023 21:09
04091ca to
2f9244f
Compare
Member
Author
|
Will do the other way in #351 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename for consistency with the same attribute on particles and to reflect its dimensionality of a length.