Skip to content

Revert PRs #3933 and #3934: restore single-job PR pipeline#3936

Merged
gladjohn merged 2 commits into
masterfrom
copilot/revert-3933-3934-changes
Jul 9, 2026
Merged

Revert PRs #3933 and #3934: restore single-job PR pipeline#3936
gladjohn merged 2 commits into
masterfrom
copilot/revert-3933-3934-changes

Conversation

Copilot AI commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Reverts the pipeline changes from #3933 ("Split PR pipeline into independent net8 stages; add MI E2E stage on MSALMSIV2") and #3934 ("Run missing unit test projects in the ADO PR build"), returning azure-pipelines.yml and related build templates to their state at 3c79dc9.

Changes

  • azure-pipelines.yml — Replaces the 4-stage parallel pipeline (Build / IntegrationTests / E2ETests / ManagedIdentityE2E) with the original single PR_build job that invokes template-run-unit-tests.yaml with e2eTestFilterCriteria: 'Category!=MI_E2E'

  • build/template-run-unit-tests.yaml — Restores the aggregated template with three inline VSTest@2 tasks (unit, integration, E2E); removes the delegation to the now-deleted granular templates

  • tests/E2E Tests/TokenAcquirerTests/TokenAcquirer.cs — Reverts the MI UAMI client ID back to 45344e7d-c562-4be6-868f-18dac789c021 ("Msal_Integration_tests", RG MSAL_MSI, shared across MSAL and Id.Web E2E)

  • Deleted 5 files introduced by Split PR pipeline into independent net8 stages; add MI E2E stage on MSALMSIV2 #3933/Run missing unit test projects in the ADO PR build #3934:

    • build/template-build-test-project.yaml
    • build/template-run-managed-identity-e2e-tests.yaml
    • build/template-test-e2e.yaml
    • build/template-test-integration.yaml
    • build/template-test-unit.yaml

…est template, original MI client ID; delete 5 added template files
Copilot AI changed the title [WIP] Revert changes from PR #3933 and PR #3934 Revert PRs #3933 and #3934: restore single-job PR pipeline Jul 9, 2026
Copilot AI requested a review from gladjohn July 9, 2026 21:28
@gladjohn
gladjohn marked this pull request as ready for review July 9, 2026 21:32
@gladjohn
gladjohn requested a review from a team as a code owner July 9, 2026 21:32
@gladjohn
gladjohn merged commit f6d7aef into master Jul 9, 2026
7 checks passed
@gladjohn
gladjohn deleted the copilot/revert-3933-3934-changes branch July 9, 2026 21:53
iarekk added a commit that referenced this pull request Jul 10, 2026
iarekk added a commit that referenced this pull request Jul 10, 2026
Restores the 4-stage PR pipeline and extra unit-test coverage from
#3933/#3934 (reverted in #3936), with two fixes so the managed-identity
E2E test runs on every pool that consumes these tests:

- TokenAcquirer MI test now reads the UAMI client id from
  IDWEB_MI_UAMI_CLIENTID, falling back to the Msal_Integration_tests
  identity (45344e7d) assigned to the Wilson pool used by the
  id4s-official pipeline. That pipeline needs no changes.
- template-run-managed-identity-e2e-tests.yaml sets IDWEB_MI_UAMI_CLIENTID
  to the msiv2uami identity (6325cd32) assigned to the MSALMSIV2 pool,
  so the Id.Web PR pipeline and IdWeb OneBranch official MI job use it.

Also re-adds the net462/net472 dotnet test steps that VSTest@2 cannot
discover on hosted agents.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
iarekk added a commit that referenced this pull request Jul 10, 2026
iarekk added a commit that referenced this pull request Jul 10, 2026
Restores the 4-stage PR pipeline and extra unit-test coverage from
#3933/#3934 (reverted in #3936), with two fixes so the managed-identity
E2E test runs on every pool that consumes these tests:

- TokenAcquirer MI test now reads the UAMI client id from
  IDWEB_MI_UAMI_CLIENTID, falling back to the Msal_Integration_tests
  identity (45344e7d) assigned to the Wilson pool used by the
  id4s-official pipeline. That pipeline needs no changes.
- template-run-managed-identity-e2e-tests.yaml sets IDWEB_MI_UAMI_CLIENTID
  to the msiv2uami identity (6325cd32) assigned to the MSALMSIV2 pool,
  so the Id.Web PR pipeline and IdWeb OneBranch official MI job use it.

Also re-adds the net472 dotnet test step that VSTest@2 cannot discover
on hosted agents.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants