Run missing unit test projects in the ADO PR build#3934
Merged
Conversation
The unit-test VSTest step only ran Microsoft.Identity.Web.Test.dll, skipping four projects the GitHub Action already covers: UI.Test, Sidecar.Tests (126 tests), OidcIdp and CustomSignedAssertion provider tests. All are built by the full solution build, so add them to the unit-test glob. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
iarekk
marked this pull request as ready for review
July 9, 2026 18:41
neha-bhargava
approved these changes
Jul 9, 2026
gladjohn
approved these changes
Jul 9, 2026
Sidecar.Tests contains SidecarEndpointsE2ETests and SidecarIntegrationTests that need a live sidecar and are filtered out in the GitHub Action. They failed on the hosted ADO agent. Add the same VSTest filter so only the in-memory Sidecar tests run, matching GH parity. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
neha-bhargava
approved these changes
Jul 9, 2026
gladjohn
approved these changes
Jul 9, 2026
Copilot AI
added a commit
that referenced
this pull request
Jul 9, 2026
…est template, original MI client ID; delete 5 added template files
This was referenced Jul 10, 2026
Closed
Closed
Merged
iarekk
added a commit
that referenced
this pull request
Jul 10, 2026
Restores the 4-stage PR pipeline and extra unit-test coverage from #3933/#3934 (reverted in #3936), with two fixes so the managed-identity E2E test runs on every pool that consumes these tests: - TokenAcquirer MI test now reads the UAMI client id from IDWEB_MI_UAMI_CLIENTID, falling back to the Msal_Integration_tests identity (45344e7d) assigned to the Wilson pool used by the id4s-official pipeline. That pipeline needs no changes. - template-run-managed-identity-e2e-tests.yaml sets IDWEB_MI_UAMI_CLIENTID to the msiv2uami identity (6325cd32) assigned to the MSALMSIV2 pool, so the Id.Web PR pipeline and IdWeb OneBranch official MI job use it. Also re-adds the net462/net472 dotnet test steps that VSTest@2 cannot discover on hosted agents. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
iarekk
added a commit
that referenced
this pull request
Jul 10, 2026
Restores the 4-stage PR pipeline and extra unit-test coverage from #3933/#3934 (reverted in #3936), with two fixes so the managed-identity E2E test runs on every pool that consumes these tests: - TokenAcquirer MI test now reads the UAMI client id from IDWEB_MI_UAMI_CLIENTID, falling back to the Msal_Integration_tests identity (45344e7d) assigned to the Wilson pool used by the id4s-official pipeline. That pipeline needs no changes. - template-run-managed-identity-e2e-tests.yaml sets IDWEB_MI_UAMI_CLIENTID to the msiv2uami identity (6325cd32) assigned to the MSALMSIV2 pool, so the Id.Web PR pipeline and IdWeb OneBranch official MI job use it. Also re-adds the net472 dotnet test step that VSTest@2 cannot discover on hosted agents. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions Bot
pushed a commit
to EelcoLos/nx-tinkering
that referenced
this pull request
Jul 14, 2026
Updated [Microsoft.Identity.Web](https://github.com/AzureAD/microsoft-identity-web) from 4.12.2 to 4.13.0. <details> <summary>Release notes</summary> _Sourced from [Microsoft.Identity.Web's releases](https://github.com/AzureAD/microsoft-identity-web/releases)._ ## 4.13.0 ## What's Changed * Categorize managed-identity E2E tests and exclude them from the PR build by @iarekk in AzureAD/microsoft-identity-web#3923 * Add more tests for TokenAcquisitionMetadata.ExpiresOn from AuthenticationResult by @neha-bhargava in AzureAD/microsoft-identity-web#3904 * Test: consolidate MI E2E test onto shared Msal_Integration_tests UAMI by @RyAuld in AzureAD/microsoft-identity-web#3926 * docs: Credential architecture internals documentation by @gladjohn in AzureAD/microsoft-identity-web#3886 * Potential fix for code scanning alert no. 35: Missing cross-site request forgery token validation by @gladjohn in AzureAD/microsoft-identity-web#3929 * Register IAuthorizationHeaderProvider2 in DI by @neha-bhargava in AzureAD/microsoft-identity-web#3927 * Bump Microsoft.Identity.Client to 4.86.0 by @neha-bhargava in AzureAD/microsoft-identity-web#3931 * Split PR pipeline into independent net8 stages; add MI E2E stage on MSALMSIV2 by @iarekk in AzureAD/microsoft-identity-web#3933 * Run missing unit test projects in the ADO PR build by @iarekk in AzureAD/microsoft-identity-web#3934 * Revert PRs #3933 and #3934: restore single-job PR pipeline by @gladjohn with @Copilot in AzureAD/microsoft-identity-web#3936 **Full Changelog**: AzureAD/microsoft-identity-web@4.12.2...4.13.0 Commits viewable in [compare view](AzureAD/microsoft-identity-web@4.12.2...4.13.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eelco Los <5102501+EelcoLos@users.noreply.github.com>
This was referenced Jul 14, 2026
Closed
Closed
Closed
Closed
Open
Open
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ADO PR build's unit-test step only globbed
Microsoft.Identity.Web.Test.dll, so four unit test projects that thedotnetcore.ymlGitHub Action already runs were never executed in the ADO run:Microsoft.Identity.Web.UI.Test(net8/net9)Sidecar.Tests(net10)OidcIdpSignedAssertionProviderTests(net9)CustomSignedAssertionProviderTests(net9)All four are part of
Microsoft.Identity.Web.slnand are already built by the Build stage's full multi-TFM build, so this just adds them to the unit-testtestAssemblyVer2glob. No new build steps.