make aadIssuerValidator public#385
Merged
Merged
Conversation
jennyf19
added a commit
that referenced
this pull request
Aug 3, 2020
* Fix nullable warnings. (#362) * fix userflow claims in addAccounToCacheFromAuthCode (#388) * make aadIssuerValidator public (#385) * Fixes Azure DevOps issue 1097354 (#387) Co-authored-by: pmaytak <34331512+pmaytak@users.noreply.github.com> Co-authored-by: jennyf19 <jeferrie@microsoft.com>
Collaborator
|
@jennyf19 @jmprieur What do you think about trying to make the config manager an injectable singleton, so it's easier to fake/replace? |
Collaborator
|
Looks good for me, @pmaytak |
jennyf19
added a commit
that referenced
this pull request
Aug 4, 2020
* initial commit to improve obo * add test & experiment w/renaming a few private methods * Jennyf/merge from master (#390) * Fix nullable warnings. (#362) * fix userflow claims in addAccounToCacheFromAuthCode (#388) * make aadIssuerValidator public (#385) * Fixes Azure DevOps issue 1097354 (#387) Co-authored-by: pmaytak <34331512+pmaytak@users.noreply.github.com> Co-authored-by: jennyf19 <jeferrie@microsoft.com> * pr feedback Co-authored-by: Jean-Marc Prieur <jmprieur@microsoft.com> Co-authored-by: pmaytak <34331512+pmaytak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#332