move obo call to earlier#383
Merged
Merged
Conversation
* Fix nullable warnings. (#362) * fix userflow claims in addAccounToCacheFromAuthCode (#388) * make aadIssuerValidator public (#385) * Fixes Azure DevOps issue 1097354 (#387) Co-authored-by: pmaytak <34331512+pmaytak@users.noreply.github.com> Co-authored-by: jennyf19 <jeferrie@microsoft.com>
Collaborator
|
@jennyf19 tested the Web API incremental tutorial which is now way faster when doing OBO. This is perceivable from the UI of the client when adding a todo item it's now super fast. |
jennyf19
marked this pull request as ready for review
August 3, 2020 17:23
pmaytak
approved these changes
Aug 4, 2020
| public const string SerializingSessionCache = "Serializing session {0}, cache key {1}. "; | ||
| public const string ClearingSessionCache = "Clearing session {0}, cache key {1}. "; | ||
|
|
||
| public const string ErrorAcquiringTokenForOboForWebApi = "Error acquiring a token for obo for a web API - MsalUiRequiredException message is: {0} ."; |
Collaborator
There was a problem hiding this comment.
Suggested change
| public const string ErrorAcquiringTokenForOboForWebApi = "Error acquiring a token for obo for a web API - MsalUiRequiredException message is: {0} ."; | |
| public const string ErrorAcquiringTokenForOboForWebApi = "Error acquiring a token for On-Behalf-Of flow for a web API - MsalUiRequiredException message is: {0} ."; | |
| ``` #Resolved |
Collaborator
Author
There was a problem hiding this comment.
i'm going to call it downstream web api instead, as OBO is not a flow, and it is confusing for a customer. thanks, peter. :)
In reply to: 464802916 [](ancestors = 464802916)
Collaborator
There was a problem hiding this comment.
Yea, downstream API makes sense.
Yea, idk I got the phrase from MS docs: https://docs.microsoft.com/en-us/azure/active-directory/develop/v2-oauth2-on-behalf-of-flow. :)
| try | ||
| { | ||
| // In web API, validatedToken will not be null | ||
| JwtSecurityToken? validatedToken = CurrentHttpContext.GetTokenUsedToCallWebAPI(); |
Collaborator
There was a problem hiding this comment.
Suggested change
| JwtSecurityToken? validatedToken = CurrentHttpContext.GetTokenUsedToCallWebAPI(); | |
| JwtSecurityToken? validatedToken = CurrentHttpContext?.GetTokenUsedToCallWebAPI(); | |
| ``` #Resolved |
Collaborator
Author
There was a problem hiding this comment.
|
|
||
| private async Task<ClaimsPrincipal?> GetAuthenticatedUserAsync(ClaimsPrincipal? user) | ||
| { | ||
| if (user == null && _httpContextAccessor.HttpContext != null) |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (user == null && _httpContextAccessor.HttpContext != null) | |
| if (user == null && _httpContextAccessor.HttpContext?.User != null) | |
| ``` #Resolved |
Collaborator
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#381
cc: @jmprieur
Needs a lot of manual testing: