Skip to content

Downgrade System.Formats.Asn1 to match ID web#5583

Merged
Avery-Dunn merged 2 commits intomainfrom
avdunn/dependency-downgrade
Nov 17, 2025
Merged

Downgrade System.Formats.Asn1 to match ID web#5583
Avery-Dunn merged 2 commits intomainfrom
avdunn/dependency-downgrade

Conversation

@Avery-Dunn
Copy link
Contributor

In this commit the System.Formats.Asn1 dependency was added to MSAL .NET: b54af18

We used version 9.0.0, which conflicts with the version 8.0.1 used in ID Web: https://github.com/AzureAD/microsoft-identity-web/blob/d993ba7980af41f866e96b9d3e15f9d6a4a49d57/Directory.Build.props#L98

Since MSAL.NET appears to compile fine with 8.0.1, this PR just downgrades the dependency here in MSAL.NET to avoid having to upgrade it in ID Web: https://github.com/AzureAD/microsoft-identity-web/pull/3583/files#r2535265213

@Avery-Dunn Avery-Dunn requested a review from a team as a code owner November 17, 2025 20:30
Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @Avery-Dunn

@Avery-Dunn Avery-Dunn merged commit 7acc1fa into main Nov 17, 2025
11 checks passed
@Avery-Dunn Avery-Dunn deleted the avdunn/dependency-downgrade branch November 17, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants