Handle changes to WithExtraQueryParameters APIs in MSAL.NET #3583
+38
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a draft: the relevant changes in MSAL.NET haven't been released yet, and these changes will not work until then.
In MSAL.NET the
WithExtraQueryParametersAPIs are receiving two changes: AzureAD/microsoft-authentication-library-for-dotnet#5536This PR is meant to handle the new API and cache behavior. It does so by making changes to the
TokenAcquisitionclass, mainly by adjusting the existingMergeExtraQueryParametershelper method to return theDictionarystyle that the newWithExtraQueryParametersAPI expects.The changes were tested with a locally built version of MSAL.NET, and all existing tests that dealt with extra query parameters worked with minimal or no changes (in
TokenAcquisitionAuthorityTests,ExtraParametersTests,DownstreamApiOptionsMergeTests, andDownstreamApiEndpointTests)