Skip to content

fixes typo in the example Entra ID authority URL in two builder classes XML comments. #5278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gladjohn merged 3 commits into from
May 14, 2025
Merged

fixes typo in the example Entra ID authority URL in two builder classes XML comments. #5278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
afab083
Update PublicClientApplicationBuilder.cs
gladjohn May 14, 2025
8fc3944
Update ConfidentialClientApplicationBuilder.cs
gladjohn May 14, 2025
0673f9c
Merge branch 'main' into gladjohn-typo
gladjohn May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/client/Microsoft.Identity.Client/AppConfig/ConfidentialClientApplicationBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ public ConfidentialClientApplicationBuilder WithGenericAuthority(string authorit
/// See https://openid.net/specs/openid-connect-core-1_0.html#Terminology
/// </summary>
/// <remarks>
/// Do not use this method with Entra ID authorities (e.g. https://login.microsfoftonline.com/common).
/// Do not use this method with Entra ID authorities (e.g. https://login.microsoftonline.com/common).
/// Use WithAuthority(string) instead.
/// </remarks>
public ConfidentialClientApplicationBuilder WithOidcAuthority(string authorityUri)
Expand Down
2 changes: 1 addition & 1 deletion src/client/Microsoft.Identity.Client/AppConfig/PublicClientApplicationBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ private PublicClientApplicationBuilder WithParentFunc(Func<object> parentFunc)
/// </summary>
/// <remarks>
/// Experimental on public clients.
/// Do not use this method with Entra ID authorities (e.g. https://login.microsfoftonline.com/common).
/// Do not use this method with Entra ID authorities (e.g. https://login.microsoftonline.com/common).
/// Use WithAuthority(string) instead.
/// </remarks>
public PublicClientApplicationBuilder WithOidcAuthority(string authorityUri)
Expand Down
Loading