fixes typo in the example Entra ID authority URL in two builder classes XML comments.#5278
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR corrects a typo in the example Entra ID authority URL in two builder classes’ XML comments.
- Fixed “https://login.microsfoftonline.com/common” to “https://login.microsoftonline.com/common” in PublicClientApplicationBuilder
- Fixed the same typo in ConfidentialClientApplicationBuilder
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/client/Microsoft.Identity.Client/AppConfig/PublicClientApplicationBuilder.cs | Corrected misspelled “microsfoftonline” in the example URL comment |
| src/client/Microsoft.Identity.Client/AppConfig/ConfidentialClientApplicationBuilder.cs | Corrected misspelled “microsfoftonline” in the example URL comment |
gladjohn
changed the title
Avery-Dunn
approved these changes
May 14, 2025
pmaytak
approved these changes
May 14, 2025
This was referenced Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5277
Changes proposed in this request
This pull request includes minor documentation corrections in the
ConfidentialClientApplicationBuilderandPublicClientApplicationBuilderclasses to fix a typo in the example URL for Entra ID authorities.Documentation fixes:
WithGenericAuthoritymethod ofConfidentialClientApplicationBuilder(https://login.microsfoftonline.com/common→https://login.microsoftonline.com/common). (src/client/Microsoft.Identity.Client/AppConfig/ConfidentialClientApplicationBuilder.cs, src/client/Microsoft.Identity.Client/AppConfig/ConfidentialClientApplicationBuilder.csL342-R342)WithParentFuncmethod ofPublicClientApplicationBuilder. (src/client/Microsoft.Identity.Client/AppConfig/PublicClientApplicationBuilder.cs, src/client/Microsoft.Identity.Client/AppConfig/PublicClientApplicationBuilder.csL229-R229)Testing
none - just comments
Performance impact
none
Documentation