Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a typo in a class name, leave a breadcrumb for porters #1584

Merged
merged 4 commits into from
Oct 8, 2021
Merged

Fix a typo in a class name, leave a breadcrumb for porters #1584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bdc2f5d
Fix a typo in a class name, leave a breadcrumb for porters
AdamBJohnsonx Oct 7, 2021
134fe9b
Update common4j/src/main/com/microsoft/identity/common/java/Authentic…
AdamBJohnsonx Oct 7, 2021
e54a520
Add changelog entry
AdamBJohnsonx Oct 7, 2021
c731c50
Merge branch 'adjoh/fix-typo' of https://github.com/AzureAD/microsoft…
AdamBJohnsonx Oct 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
V.Next
----------
- [MAJOR] Rename LobalBroadcasterAliases to LocalBroadcasterAliases (#1584)
- [PATCH] Make it clear if adding a query param should overwrite or leave as is (#1581)
- [PATCH] Handle the scenario where broker activity is killed wrongly. (#1568)
- [MINOR] Add GetOsForMats to IDeviceMetadata (#1552)
Expand Down
2 changes: 1 addition & 1 deletion common/src/main/java/com/microsoft/identity/common/internal/broker/BrokerActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
import com.microsoft.identity.common.java.util.ported.LocalBroadcaster;
import com.microsoft.identity.common.logging.Logger;

import static com.microsoft.identity.common.java.AuthenticationConstants.LobalBroadcasterAliases.RETURN_BROKER_INTERACTIVE_ACQUIRE_TOKEN_RESULT;
import static com.microsoft.identity.common.java.AuthenticationConstants.LocalBroadcasterAliases.RETURN_BROKER_INTERACTIVE_ACQUIRE_TOKEN_RESULT;
import static com.microsoft.identity.common.java.AuthenticationConstants.LocalBroadcasterFields.REQUEST_CODE;
import static com.microsoft.identity.common.java.AuthenticationConstants.LocalBroadcasterFields.RESULT_CODE;
import static com.microsoft.identity.common.java.AuthenticationConstants.UIRequest.BROKER_FLOW;
Expand Down
2 changes: 1 addition & 1 deletion ...rc/main/java/com/microsoft/identity/common/internal/controllers/BrokerMsalController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
import static com.microsoft.identity.common.internal.broker.ipc.BrokerOperationBundle.Operation.MSAL_SIGN_OUT_FROM_SHARED_DEVICE;
import static com.microsoft.identity.common.internal.broker.ipc.BrokerOperationBundle.Operation.MSAL_SSO_TOKEN;
import static com.microsoft.identity.common.internal.controllers.BrokerOperationExecutor.BrokerOperation;
import static com.microsoft.identity.common.java.AuthenticationConstants.LobalBroadcasterAliases.RETURN_BROKER_INTERACTIVE_ACQUIRE_TOKEN_RESULT;
import static com.microsoft.identity.common.java.AuthenticationConstants.LocalBroadcasterAliases.RETURN_BROKER_INTERACTIVE_ACQUIRE_TOKEN_RESULT;
import static com.microsoft.identity.common.java.AuthenticationConstants.LocalBroadcasterFields.REQUEST_CODE;
import static com.microsoft.identity.common.java.AuthenticationConstants.LocalBroadcasterFields.RESULT_CODE;

Expand Down
4 changes: 2 additions & 2 deletions ...n/java/com/microsoft/identity/common/internal/providers/oauth2/AuthorizationFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
import com.microsoft.identity.common.logging.DiagnosticContext;
import com.microsoft.identity.common.logging.Logger;

import static com.microsoft.identity.common.java.AuthenticationConstants.LobalBroadcasterAliases.CANCEL_AUTHORIZATION_REQUEST;
import static com.microsoft.identity.common.java.AuthenticationConstants.LobalBroadcasterAliases.RETURN_AUTHORIZATION_REQUEST_RESULT;
import static com.microsoft.identity.common.java.AuthenticationConstants.LocalBroadcasterAliases.CANCEL_AUTHORIZATION_REQUEST;
import static com.microsoft.identity.common.java.AuthenticationConstants.LocalBroadcasterAliases.RETURN_AUTHORIZATION_REQUEST_RESULT;
import static com.microsoft.identity.common.java.AuthenticationConstants.LocalBroadcasterFields.REQUEST_CODE;
import static com.microsoft.identity.common.java.AuthenticationConstants.UIRequest.BROWSER_FLOW;

Expand Down
4 changes: 2 additions & 2 deletions ...microsoft/identity/common/internal/providers/oauth2/CurrentTaskAuthorizationFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@

import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;

import static com.microsoft.identity.common.java.AuthenticationConstants.LobalBroadcasterAliases.CANCEL_AUTHORIZATION_REQUEST;
import static com.microsoft.identity.common.java.AuthenticationConstants.LobalBroadcasterAliases.RETURN_AUTHORIZATION_REQUEST_RESULT;
import static com.microsoft.identity.common.java.AuthenticationConstants.LocalBroadcasterAliases.CANCEL_AUTHORIZATION_REQUEST;
import static com.microsoft.identity.common.java.AuthenticationConstants.LocalBroadcasterAliases.RETURN_AUTHORIZATION_REQUEST_RESULT;
import static com.microsoft.identity.common.java.AuthenticationConstants.LocalBroadcasterFields.REQUEST_CODE;
import static com.microsoft.identity.common.java.AuthenticationConstants.UIRequest.BROWSER_FLOW;

Expand Down
4 changes: 2 additions & 2 deletions common4j/src/main/com/microsoft/identity/common/java/AuthenticationConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,15 +622,15 @@ public static final class SdkPlatformFields {
* Aliases for broadcasting events
* to be used with {@link LocalBroadcaster}
*/
public static final class LobalBroadcasterAliases {
public static final class LocalBroadcasterAliases {

/**
* an alias specifying that the current authorization action should be cancelled.
*/
public static final String CANCEL_AUTHORIZATION_REQUEST = "cancel_authorization_request";

/**
* an alias that the intent contains authorization results.
* An alias that the intent contains authorization results, was formerly RETURN_INTERACTIVE_REQUEST_RESULT.
*/
public static final String RETURN_AUTHORIZATION_REQUEST_RESULT = "return_authorization_request_result";

Expand Down
4 changes: 2 additions & 2 deletions common4j/src/main/com/microsoft/identity/common/java/controllers/CommandDispatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
// THE SOFTWARE.
package com.microsoft.identity.common.java.controllers;

import static com.microsoft.identity.common.java.AuthenticationConstants.LobalBroadcasterAliases.CANCEL_AUTHORIZATION_REQUEST;
import static com.microsoft.identity.common.java.AuthenticationConstants.LobalBroadcasterAliases.RETURN_AUTHORIZATION_REQUEST_RESULT;
import static com.microsoft.identity.common.java.AuthenticationConstants.LocalBroadcasterAliases.CANCEL_AUTHORIZATION_REQUEST;
import static com.microsoft.identity.common.java.AuthenticationConstants.LocalBroadcasterAliases.RETURN_AUTHORIZATION_REQUEST_RESULT;
import static com.microsoft.identity.common.java.AuthenticationConstants.LocalBroadcasterFields.REQUEST_CODE;
import static com.microsoft.identity.common.java.AuthenticationConstants.LocalBroadcasterFields.RESULT_CODE;
import static com.microsoft.identity.common.java.AuthenticationConstants.SdkPlatformFields.PRODUCT;
Expand Down