Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in a class name, leave a breadcrumb for porters #1584

Merged
merged 4 commits into from
Oct 8, 2021

Conversation

AdamBJohnsonx
Copy link
Contributor

@AdamBJohnsonx AdamBJohnsonx commented Oct 7, 2021

When we changed the name of this constant, we left no path for a user to discover where it had gone. We also misspelled local, but nobody would ever have known that if I hadn't had to go on a great search for the missing constant.

In general, if you're renaming public constants, it would be nice to leave the previous name in a comment, so that at least people using code search could discover where it went.

@AdamBJohnsonx AdamBJohnsonx merged commit ef1ec7a into dev Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants