Fix a typo in a class name, leave a breadcrumb for porters #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamBJohnsonx
requested review from
rpdome,
shahzaibj and
shoatman
as code owners
shahzaibj
reviewed
Oct 7, 2021
common4j/src/main/com/microsoft/identity/common/java/AuthenticationConstants.java
Outdated
Show resolved
Hide resolved
shahzaibj
approved these changes
Oct 7, 2021
…ationConstants.java Co-authored-by: Shahzaib <[email protected]>
rpdome
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we changed the name of this constant, we left no path for a user to discover where it had gone. We also misspelled local, but nobody would ever have known that if I hadn't had to go on a great search for the missing constant.
In general, if you're renaming public constants, it would be nice to leave the previous name in a comment, so that at least people using code search could discover where it went.