-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for mocking final classes in some instrumented tests #1602
Conversation
Grabbing a snapshot of the failing tests, since builds aren't long-term archived
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
License files
More or less, these changes seem fine - the tests broken in #1587 seem to be resolved. Let's fix the license declarations in these files, resolve the submodule conflict and send it round for another signoff |
|
I think we should update the description here because as I understand there were really a couple of issues:
I think this PR addresses both of those issues and we should call that out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a minor feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we can make the pipeline pass...then I can approve it
@paulkagiri this is blocking my PR, could we get this fixed and merge? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paulkagiri . I disabled the tests for now, but we should definitely get this up and running by end of month.
9e6099e
to
f776087
Compare
167f03d
to
5d8193c
Compare
adal/src/test/java/com/microsoft/aad/adal/SigningInfoShadow.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment
Already addressed the requested changes
This PR is meant to address failures noted in the instrumented tests. The failures were happening because Mockito does not allow mocking final classes and thus a workaround has been arrived where a custom PackageInfo and respective SigningInfo has been developed.
Depends on: AzureAD/microsoft-authentication-library-common-for-android#1454