Update Nimbus Version 8.2 -> 9.9 #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzaibj
previously approved these changes
May 3, 2021
shahzaibj
previously approved these changes
May 3, 2021
|
It appears that this PR pipeline was broken by the build changes here: Related, it looks like @rpdome saw this too based on the changes in and fixed it/worked around it in: @paulkagiri It seems your PR #1256 broke these tests, can you take a look to unblock?
|
iambmelt
changed the title
|
Need to update this PR to resolve conflicts |
iambmelt
commented
May 11, 2021
iambmelt
commented
May 11, 2021
adal/src/androidTest/java/com/microsoft/aad/adal/BrokerProxyTests.java
Outdated
Show resolved
Hide resolved
iambmelt
commented
May 11, 2021
adal/src/androidTest/java/com/microsoft/aad/adal/PackageHelperTests.java
Outdated
Show resolved
Hide resolved
|
Tests are failing due to unmerged changes in #1602 -- I don't think there changes need to block on that |
shahzaibj
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns ADAL Nimbus version with Common's
AzureAD/microsoft-authentication-library-common-for-android#1346