Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace download with more in-house implementation. #567

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

Tatsinnit
Copy link
Member

@Tatsinnit Tatsinnit commented Mar 19, 2024

Nice @peterbom! We need this because we have a package in use called download which is not updated for last 4 years and this in-house implementation saves us any cross package dependency and future security issues.

Thanks heaps, @peterbom ❤️❤️

Screenshot 2024-03-19 at 7 28 40 PM

@Tatsinnit
Copy link
Member Author

Tatsinnit commented Mar 19, 2024

@Tatsinnit Tatsinnit added bug Something isn't working enhancement 🚀 New feature or request or improvements on existing code. labels Mar 19, 2024
Copy link
Contributor

@peterbom peterbom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still an outstanding work item for this, #568, but we can address this later.

@Tatsinnit Tatsinnit merged commit 0520c61 into Azure:main Mar 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement 🚀 New feature or request or improvements on existing code.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants