Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direct node-fetch dependency #568

Closed
peterbom opened this issue Mar 19, 2024 · 0 comments · Fixed by #723
Closed

Add direct node-fetch dependency #568

peterbom opened this issue Mar 19, 2024 · 0 comments · Fixed by #723
Assignees
Labels
enhancement 🚀 New feature or request or improvements on existing code.

Comments

@peterbom
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We don't have a direct dependency on node-fetch.

This will become a problem if/when we remove the cross-fetch dependency (which is likely to happen during the fix for #552), which indirectly ensures we have the node-fetch library needed for downloads.

Ideally we would have added a direct reference to node-fetch as part of #567, but doing this caused a patch version bump to several @microsoft/applicationinsights packages that are transitive dependencies of @vscode/extension-telemetry, which unearthed a bug that causes the extension to fail to load.

When the above bug is fixed, we can remove the @types/node-fetch dependency and add node-fetch directly.

@peterbom peterbom added the enhancement 🚀 New feature or request or improvements on existing code. label Mar 19, 2024
@peterbom peterbom self-assigned this Mar 19, 2024
@Tatsinnit Tatsinnit self-assigned this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚀 New feature or request or improvements on existing code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants