Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARM Library reorganization #945

Merged
merged 33 commits into from
Jun 12, 2024
Merged

ARM Library reorganization #945

merged 33 commits into from
Jun 12, 2024

Conversation

allenjzhang
Copy link
Member

  • Created fully versioned Azure.ResourceManager.CommonTypes subnamespace
  • Moving all common type definitions/parameters into corresponding tsp files for later easy swagger generation
  • Adding back compat layers so all existing entities moved from Foundations continue to work (via alias)
  • Added default logic to add @useDependency to CommonType reference via @armProviderNamespace and @armCommonTypeVersion decorators to prevent breaking change.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jun 1, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @azure-tools/typespec-azure-resource-manager
Show changes

@azure-tools/typespec-azure-resource-manager - internal ✏️

Reorganize ARM library internal models into fully version controlled Azure.ResourceManager.CommontTypes namespace.

@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/945/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/945/

@pshao25
Copy link
Member

pshao25 commented Jun 3, 2024

I think we should change the swagger emitter from "read metadata from armCommonTypeVersion" to "consume data from compiler output"?

markcowl
markcowl requested changes Jun 3, 2024
View reviewed changes
packages/typespec-azure-resource-manager/lib/common-types/common-types.tsp Show resolved Hide resolved
packages/typespec-azure-resource-manager/lib/common-types/commontypes.private.decorators.tsp Show resolved Hide resolved
packages/typespec-azure-resource-manager/lib/foundations/backcompat.tsp Show resolved Hide resolved
packages/typespec-azure-resource-manager/lib/common-types/extended-location-ref.tsp Show resolved Hide resolved
packages/typespec-azure-resource-manager/lib/common-types/managed-identity-ref.tsp Show resolved Hide resolved
packages/typespec-azure-resource-manager/scripts/common-types.tsp Outdated Show resolved Hide resolved
packages/typespec-azure-resource-manager/scripts/common-types.tsp Outdated Show resolved Hide resolved
packages/typespec-azure-resource-manager/src/common-types.ts Outdated Show resolved Hide resolved
packages/typespec-azure-resource-manager/src/common-types.ts Show resolved Hide resolved
packages/typespec-azure-resource-manager/src/commontypes.private.decorators.ts Show resolved Hide resolved
@XiaofeiCao
Copy link
Contributor

Would you also help address the visibility discrepancy with swagger too? Thanks!

This was referenced Jun 7, 2024
Closed
Closed
Closed
Closed
Closed
@allenjzhang allenjzhang mentioned this pull request Jun 7, 2024
Closed
4 tasks
@allenjzhang allenjzhang mentioned this pull request Jun 11, 2024
Closed
markcowl
markcowl requested changes Jun 11, 2024
View reviewed changes
packages/samples/specs/resource-manager/resource-common-properties/common-properties/main.tsp Outdated Show resolved Hide resolved
packages/samples/specs/resource-manager/resource-common-properties/managed-identity/main.tsp Outdated Show resolved Hide resolved
packages/typespec-azure-resource-manager/lib/common-types/private-links.tsp Outdated Show resolved Hide resolved
packages/typespec-azure-resource-manager/lib/common-types/types-ref.tsp Show resolved Hide resolved
packages/typespec-azure-resource-manager/lib/common-types/types-ref.tsp Show resolved Hide resolved
packages/typespec-azure-resource-manager/lib/foundations/arm.foundations.tsp Show resolved Hide resolved
packages/typespec-azure-resource-manager/src/lib.ts Outdated Show resolved Hide resolved
packages/typespec-azure-resource-manager/lib/common-types/types.tsp Show resolved Hide resolved
packages/typespec-azure-resource-manager/lib/common-types/types.tsp Outdated Show resolved Hide resolved
markcowl
markcowl reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the failures are due to a conflict, and just rebuilding and regenerating samples

@allenjzhang allenjzhang added this pull request to the merge queue Jun 12, 2024
Merged via the queue into Azure:main with commit fe90e20 Jun 12, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheeguerin timotheeguerin timotheeguerin left review comments

@pshao25 pshao25 pshao25 left review comments

@markcowl markcowl markcowl approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@allenjzhang @azure-sdk @pshao25 @XiaofeiCao @timotheeguerin @markcowl