Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Inconsistent OperationStatusResult model in tsp #939

Closed
4 tasks done
harshjangid opened this issue May 30, 2024 · 2 comments
Closed
4 tasks done

[Bug]: Inconsistent OperationStatusResult model in tsp #939

harshjangid opened this issue May 30, 2024 · 2 comments
Assignees
@allenjzhang
Labels
bug Something isn't working lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library
Milestone
[2024] July

Comments

@harshjangid
Copy link
Member

harshjangid commented May 30, 2024 •
edited
Loading

Describe the bug

The current OperationStatusResult model in typespec has mandatory opeartions parameter, but according to this. It must be optional.

image

Reproduction

Inspect OperationStatusResult model from Azure.ResourceManager.Foundations.OperationStatusResult

Checklist

  • Follow our Code of Conduct
  • Check that this issue is about the Azure libraries for typespec. For bug in the typespec language or core libraries file it in the TypeSpec repo
  • Check that there isn't already an issue that request the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@harshjangid harshjangid added the bug Something isn't working label May 30, 2024
@markcowl markcowl added this to the [2024] July milestone May 30, 2024
@markcowl markcowl added the lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library label May 30, 2024
@pshao25
Copy link
Member

pshao25 commented Jun 3, 2024

Additional information: in swagger, it is optional as well.
https://github.com/Azure/azure-rest-api-specs/blob/b5512186602fbe490d273aab7ebddc21f8e7f855/specification/common-types/resource-management/v5/types.json#L463-L468

@allenjzhang
Copy link
Member

Fixed in pending PR. #945

@allenjzhang allenjzhang self-assigned this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allenjzhang allenjzhang

Labels
bug Something isn't working lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library
Projects
None yet
Milestone
[2024] July
Development

No branches or pull requests
4 participants
@markcowl @allenjzhang @harshjangid @pshao25