-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit of ARM bug fix and rename/reorg #762
Conversation
All changed packages have been documented.
Show changes
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/762/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/762/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few questions and comments, but the changes look good.
packages/samples/specs/resource-manager/liftr.confluent/confluent.tsp
Outdated
Show resolved
Hide resolved
packages/typespec-azure-resource-manager/lib/common-types/types.tsp
Outdated
Show resolved
Hide resolved
packages/typespec-azure-resource-manager/lib/common-types/types.tsp
Outdated
Show resolved
Hide resolved
… type check on operation and model templates.
packages/typespec-azure-resource-manager/lib/private.models.tsp
Outdated
Show resolved
Hide resolved
packages/typespec-azure-resource-manager/test/enforce-constraint.test.ts
Show resolved
Hide resolved
Updated and added |
This change contains following changes:
extendedLocation
with optional and READ, CREATENote: both the
#deprecated alias
and in some casesTrackResource<T>
andFoundations.TrackResource
may cause spec break.rest-api-specs/typespec-next
will be checked and updated if this is approved.