Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit of ARM bug fix and rename/reorg #762

Merged
merged 20 commits into from
May 7, 2024

Conversation

allenjzhang
Copy link
Member

@allenjzhang allenjzhang commented Apr 30, 2024

This change contains following changes:

  • Updated extendedLocation with optional and READ, CREATE
  • Renamed base common types to be consistent with ARM common type, included backcompat aliases with #deprecate
    • ArmResource -> Resource
    • TrackResourceBase -> TrackResource
    • ProxyResourceBase -> ProxyResource
    • ExtensionResourceBase -> ExtensionResource
    • ResourceSku -> Sku
    • ResourcePlan -> Plan

Note: both the #deprecated alias and in some cases TrackResource<T> and Foundations.TrackResource may cause spec break. rest-api-specs/typespec-next will be checked and updated if this is approved.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 30, 2024

All changed packages have been documented.

  • @azure-tools/typespec-azure-resource-manager
Show changes

@azure-tools/typespec-azure-resource-manager - deprecation ✏️

Renaming internal TypeSpec ARM foundation model names to be consistent with ARM common-type definitions.,> However, these are Azure.Resource.Manager.Foundations models that would not normally be used directly in service specs.,> ,> - Deprecate Foundations.ArmResource. Foundations.Resource should be used instead.,> ,> - Deprecate Foundations.ResourceSkuType. Foundations.Sku should be used instead.,> ,> - Deprecate Foundations.ResourcePlanType. Foundations.Plan should be used instead.,> ,> - Deprecate Foundations.TrackedResourceBase. Foundations.TrackedResource should be used instead.,> ,> - Deprecate Foundations.ProxyResourceBase. Foundations.ProxyResource should be used instead.,> ,> - Deprecate Foundations.ExtensionResourceBase. Foundations.ExtensionResource should be used instead.

@azure-sdk
Copy link
Collaborator

Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions and comments, but the changes look good.

@allenjzhang
Copy link
Member Author

Updated and added actionMessage. Added to test scenarios.

@allenjzhang allenjzhang enabled auto-merge May 7, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants