-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arm, remove special handling for ARM types #2749
arm, remove special handling for ARM types #2749
Conversation
// skip models under "Azure.ResourceManager" | ||
if (this.isArm() && schema.language.default?.namespace?.startsWith("Azure.ResourceManager")) { | ||
return; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This deduplication logic is due to same dummy resource schema being added many times here:
https://github.com/Azure/autorest.java/pull/2749/files#diff-14fdfb2e0df46da414f4d04a218f03e4e5f2737d3a9672b9c4e4feb16419445eL2160
ArmResource is deprecated but not removed. Do we still need this till it get removed? |
I searched current specs repo, seems (Arm)Resource is only used in template parameters as : https://github.com/search?q=repo%3AAzure%2Fazure-rest-api-specs+%22ArmResource%22&type=code&p=1 (Arm)Resource is used as base model for all Tracked/Proxy/ExtensionResource(Base). I guess service is not allowed to let its models directly extend |
Offline sync with Chenjie, service will not use |
typespec-azure-resource-manager
has fixed the naming issue: Azure/typespec-azure#762Our special handling for
Resource
,ProxyResource
andArmResource
is no longer needed.