Skip to content

Fix flatten read-only properties case #4006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jiao Di (MSFT) (v-jiaodi) merged 6 commits into from
Mar 6, 2026
Merged

Fix flatten read-only properties case #4006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8de6d55
fix flatten case
v-jiaodi Mar 4, 2026
33a0c0c
update
v-jiaodi Mar 4, 2026
417f121
format
v-jiaodi Mar 5, 2026
54592de
update
v-jiaodi Mar 5, 2026
8a3426d
remove require flatten property
v-jiaodi Mar 5, 2026
7109875
Merge branch 'main' into fix-flatten-case
v-jiaodi Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .chronus/changes/fix-flatten-property-tests-2026-03-04-10-56-42.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
changeKind: fix
packages:
- "@azure-tools/azure-http-specs"
---

Fix test cases for flatten property with read-only properties.
17 changes: 7 additions & 10 deletions packages/azure-http-specs/specs/azure/client-generator-core/flatten-property/main.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,11 +172,7 @@ model Solution {

#suppress "@azure-tools/typespec-azure-core/no-legacy-usage" "Testing backcompat"
@global.Azure.ClientGenerator.Core.Legacy.flattenProperty
properties: SolutionProperties;

#suppress "@azure-tools/typespec-azure-core/no-legacy-usage" "Testing backcompat"
@global.Azure.ClientGenerator.Core.Legacy.flattenProperty
propertiesOptional?: SolutionProperties;
properties?: SolutionProperties;
}

@scenario
Expand All @@ -186,7 +182,6 @@ model Solution {

Expected behavior: When flattening a property that contains only read-only properties:
- For input (write): Read-only properties should not appear in the input model, regardless of flattening
- For response (read): Read-only properties should be flattened to the parent model level

The `properties` and `propertiesOptional` fields contain only read-only properties (`solutionId`,
`title`, `content`). These should be flattened into the parent `Solution` model in the response.
Expand All @@ -198,13 +193,15 @@ model Solution {
}
```

Expected response body (properties flattened to parent level):
Expected response body:
```json
{
"name": "foo",
"solutionId": "solution1",
"title": "Solution Title",
"content": "Solution Content"
"properties": {
"solutionId": "solution1",
"title": "Solution Title",
"content": "Solution Content"
}
}
```
""")
Expand Down
8 changes: 5 additions & 3 deletions packages/azure-http-specs/specs/azure/client-generator-core/flatten-property/mockapi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,11 @@ Scenarios.Azure_ClientGenerator_Core_FlattenProperty_putFlattenReadOnlyModel = p
},
{
name: "foo",
solutionId: "solution1",
title: "Solution Title",
content: "Solution Content",
properties: {
solutionId: "solution1",
title: "Solution Title",
content: "Solution Content",
},
},
),
);
Loading