Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Azure.ResourceManager.CommonTypes v6 #1689

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
587365c
Generate Azure.ResourceManager.CommonTypes v6
AlitzelMendez Oct 15, 2024
f46fa45
Add common-types without changes and summary of changes
AlitzelMendez Oct 16, 2024
9f29d8b
Documentation
AlitzelMendez Oct 16, 2024
e795e49
Merge branch 'main' into add-common-types-v6
AlitzelMendez Oct 16, 2024
9427534
Merge branch 'main' into add-common-types-v6
AlitzelMendez Oct 22, 2024
15ddd6b
sort-swagger for exiting v6 swaggers
AlitzelMendez Oct 23, 2024
b29981e
Merge branch 'add-common-types-v6' of https://github.com/AlitzelMende…
AlitzelMendez Oct 23, 2024
7ea83db
Merge branch 'main' into add-common-types-v6
AlitzelMendez Oct 24, 2024
1ab77f8
Merge branch 'main' into add-common-types-v6
AlitzelMendez Oct 30, 2024
3b5fb67
-Feedback: add @@pagedResult decorator
AlitzelMendez Oct 31, 2024
6265935
Generate Azure.ResourceManager.CommonTypes v6
AlitzelMendez Oct 15, 2024
9ed00b8
Add common-types without changes and summary of changes
AlitzelMendez Oct 16, 2024
6983d1b
Documentation
AlitzelMendez Oct 16, 2024
1dc1c1d
sort-swagger for exiting v6 swaggers
AlitzelMendez Oct 23, 2024
ddfb9f3
-Feedback: add @@pagedResult decorator
AlitzelMendez Oct 31, 2024
334ae1a
Merge branch 'add-common-types-v6' of https://github.com/AlitzelMende…
AlitzelMendez Nov 4, 2024
de2af51
Merge branch 'main' into add-common-types-v6
AlitzelMendez Nov 5, 2024
0816481
Different approach: Validate if this will be a breaking change
AlitzelMendez Nov 5, 2024
475eefa
Documentation
AlitzelMendez Nov 5, 2024
ec1eb43
Create new model for the previous scenario
AlitzelMendez Nov 7, 2024
07b8270
Merge branch 'main' into add-common-types-v6
AlitzelMendez Nov 7, 2024
3692124
Adding deprecation and documentation
AlitzelMendez Nov 12, 2024
5728049
Add suppress warning for test
AlitzelMendez Nov 13, 2024
babc7fe
Documentation
AlitzelMendez Nov 14, 2024
6cc7f28
Merge remote-tracking branch 'origin/main' into add-common-types-v6
AlitzelMendez Nov 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .chronus/changes/add-common-types-v6-2024-9-16-14-19-21.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
changeKind: feature
packages:
- "@azure-tools/typespec-azure-resource-manager"
---

Add common-types v6 with changes in managed identity, private links, and types.
110 changes: 110 additions & 0 deletions packages/samples/common-types/existing/v6/managedidentity.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,110 @@
{
"swagger": "2.0",
"info": {
"title": "Common types",
"version": "6.0"
},
"paths": {},
"definitions": {
"ManagedServiceIdentity": {
"type": "object",
"description": "Managed service identity (system assigned and/or user assigned identities)",
"properties": {
"principalId": {
"type": "string",
"format": "uuid",
"description": "The service principal ID of the system assigned identity. This property will only be provided for a system assigned identity.",
"readOnly": true
},
"tenantId": {
"type": "string",
"format": "uuid",
"description": "The tenant ID of the system assigned identity. This property will only be provided for a system assigned identity.",
"readOnly": true
},
"type": {
"$ref": "#/definitions/ManagedServiceIdentityType"
},
"userAssignedIdentities": {
"type": "object",
"description": "The set of user assigned identities associated with the resource. The userAssignedIdentities dictionary keys will be ARM resource ids in the form: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ManagedIdentity/userAssignedIdentities/{identityName}. The dictionary values can be empty objects ({}) in requests.",
"additionalProperties": {
"$ref": "#/definitions/UserAssignedIdentity",
"x-nullable": true
}
}
},
"required": [
"type"
]
},
"ManagedServiceIdentityType": {
"type": "string",
"description": "Type of managed service identity (where both SystemAssigned and UserAssigned types are allowed).",
"enum": [
"None",
"SystemAssigned",
"UserAssigned",
"SystemAssigned,UserAssigned"
],
"x-ms-enum": {
"name": "ManagedServiceIdentityType",
"modelAsString": true
}
},
"SystemAssignedServiceIdentity": {
"type": "object",
"description": "Managed service identity (either system assigned, or none)",
"properties": {
"principalId": {
"type": "string",
"format": "uuid",
"description": "The service principal ID of the system assigned identity. This property will only be provided for a system assigned identity.",
"readOnly": true
},
"tenantId": {
"type": "string",
"format": "uuid",
"description": "The tenant ID of the system assigned identity. This property will only be provided for a system assigned identity.",
"readOnly": true
},
"type": {
"$ref": "#/definitions/SystemAssignedServiceIdentityType"
}
},
"required": [
"type"
]
},
"SystemAssignedServiceIdentityType": {
"type": "string",
"description": "Type of managed service identity (either system assigned, or none).",
"enum": [
"None",
"SystemAssigned"
],
"x-ms-enum": {
"name": "SystemAssignedServiceIdentityType",
"modelAsString": true
}
},
"UserAssignedIdentity": {
"type": "object",
"description": "User assigned identity properties",
"properties": {
"principalId": {
"type": "string",
"format": "uuid",
"description": "The principal ID of the assigned identity.",
"readOnly": true
},
"clientId": {
"type": "string",
"format": "uuid",
"description": "The client ID of the assigned identity.",
"readOnly": true
}
}
}
}
}
202 changes: 202 additions & 0 deletions packages/samples/common-types/existing/v6/privatelinks.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,202 @@
{
"swagger": "2.0",
"info": {
"title": "Common types",
"version": "6.0"
},
"paths": {},
"definitions": {
"PrivateEndpoint": {
"type": "object",
"description": "The private endpoint resource.",
"properties": {
"id": {
"type": "string",
"description": "The ARM identifier for private endpoint.",
"readOnly": true
}
}
},
"PrivateEndpointConnection": {
"type": "object",
"description": "The private endpoint connection resource.",
"properties": {
"properties": {
"$ref": "#/definitions/PrivateEndpointConnectionProperties",
"description": "Resource properties.",
"x-ms-client-flatten": true
}
},
"allOf": [
{
"$ref": "../v5/types.json#/definitions/Resource"
}
]
},
"PrivateEndpointConnectionListResult": {
"type": "object",
"description": "List of private endpoint connections associated with the specified resource.",
"properties": {
"value": {
"type": "array",
"description": "Array of private endpoint connections.",
"items": {
"$ref": "#/definitions/PrivateEndpointConnection"
}
},
"nextLink": {
"type": "string",
"format": "uri",
"description": "URL to get the next set of operation list results (if there are any).",
"readOnly": true
}
}
},
"PrivateEndpointConnectionProperties": {
"type": "object",
"description": "Properties of the private endpoint connection.",
"properties": {
"groupIds": {
"type": "array",
"description": "The group ids for the private endpoint resource.",
"items": {
"type": "string"
},
"readOnly": true
},
"privateEndpoint": {
"$ref": "#/definitions/PrivateEndpoint",
"description": "The private endpoint resource."
},
"privateLinkServiceConnectionState": {
"$ref": "#/definitions/PrivateLinkServiceConnectionState",
"description": "A collection of information about the state of the connection between service consumer and provider."
},
"provisioningState": {
"$ref": "#/definitions/PrivateEndpointConnectionProvisioningState",
"description": "The provisioning state of the private endpoint connection resource."
}
},
"required": [
"privateLinkServiceConnectionState"
]
},
"PrivateEndpointConnectionProvisioningState": {
"type": "string",
"description": "The current provisioning state.",
"enum": [
"Succeeded",
"Creating",
"Deleting",
"Failed"
],
"x-ms-enum": {
"name": "PrivateEndpointConnectionProvisioningState",
"modelAsString": true
},
"readOnly": true
},
"PrivateEndpointServiceConnectionStatus": {
"type": "string",
"description": "The private endpoint connection status.",
"enum": [
"Pending",
"Approved",
"Rejected"
],
"x-ms-enum": {
"name": "PrivateEndpointServiceConnectionStatus",
"modelAsString": true
}
},
"PrivateLinkResource": {
"type": "object",
"description": "A private link resource.",
"properties": {
"properties": {
"$ref": "#/definitions/PrivateLinkResourceProperties",
"description": "Resource properties.",
"x-ms-client-flatten": true
}
},
"allOf": [
{
"$ref": "../v5/types.json#/definitions/Resource"
}
]
},
"PrivateLinkResourceListResult": {
"type": "object",
"description": "A list of private link resources.",
"properties": {
"value": {
"type": "array",
"description": "Array of private link resources",
"items": {
"$ref": "#/definitions/PrivateLinkResource"
}
},
"nextLink": {
"type": "string",
"format": "uri",
"description": "URL to get the next set of operation list results (if there are any).",
"readOnly": true
}
}
},
"PrivateLinkResourceProperties": {
"type": "object",
"description": "Properties of a private link resource.",
"properties": {
"groupId": {
"type": "string",
"description": "The private link resource group id.",
"readOnly": true
},
"requiredMembers": {
"type": "array",
"description": "The private link resource required member names.",
"items": {
"type": "string"
},
"readOnly": true
},
"requiredZoneNames": {
"type": "array",
"description": "The private link resource private link DNS zone name.",
"items": {
"type": "string"
}
}
}
},
"PrivateLinkServiceConnectionState": {
"type": "object",
"description": "A collection of information about the state of the connection between service consumer and provider.",
"properties": {
"status": {
"$ref": "#/definitions/PrivateEndpointServiceConnectionStatus",
"description": "Indicates whether the connection has been Approved/Rejected/Removed by the owner of the service."
},
"description": {
"type": "string",
"description": "The reason for approval/rejection of the connection."
},
"actionsRequired": {
"type": "string",
"description": "A message indicating if changes on the service provider require any updates on the consumer."
}
}
}
},
"parameters": {
"PrivateEndpointConnectionName": {
"name": "privateEndpointConnectionName",
"in": "path",
"description": "The name of the private endpoint connection associated with the Azure resource.",
"required": true,
"type": "string",
"x-ms-parameter-location": "method"
}
}
}
Loading
Loading