Generate Azure.ResourceManager.CommonTypes v6 #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
|
@allenjzhang, I started this draft pull request with the v6 common types, please lets talk about the common types that doesn't exist yet |
I talked with Allen about this offline, he mentioned that for the common-types that are not present of v6 we shouldn't do any change but still produce the types |
AlitzelMendez
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
AlitzelMendez
changed the title
4 tasks
markcowl
requested changes
Oct 30, 2024
packages/typespec-azure-resource-manager/lib/common-types/private-links.tsp
Show resolved
Hide resolved
packages/typespec-azure-resource-manager/lib/common-types/private-links.tsp
Show resolved
Hide resolved
- Add -ref file changes
abatishchev
force-pushed
the
add-common-types-v6
branch
from
3b5fb67
to
ddfb9f3
Compare
allenjzhang
approved these changes
Nov 4, 2024
|
Updating -ref files is a lot of hassle. We need to look for a way to simplify/eliminate the process. Opened #1800 to track this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 3 common types that changed on this version: https://github.com/Azure/azure-rest-api-specs/tree/main/specification/common-types/resource-management/v6
issue: #1028