New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rule for RPC-Policy-V1-03: no properties of type object without a schema #1555

Open

AlitzelMendez wants to merge 10 commits into Azure:main from AlitzelMendez:almend/Rule

+197 −0

Member

AlitzelMendez commented Sep 18, 2024

Issue: #1426

AlitzelMendez added 3 commits

September 17, 2024 16:57


          Add rule for RPC-Policy-V1-03: no properties of type object without a…

cfbea38

… schema


          Merge branch 'main' into almend/Rule

17d804c


          Add changes summary

a10f292

Collaborator

azure-sdk commented Sep 18, 2024 •

edited

Loading

All changed packages have been documented.

✅ @azure-tools/typespec-azure-resource-manager
✅ @azure-tools/typespec-azure-rulesets

Show changes

`@azure-tools/typespec-azure-resource-manager` - feature ✏️

Add no-empty-model rule

`@azure-tools/typespec-azure-rulesets` - feature ✏️

Add no-empty-model rule to ruleset

Collaborator

azure-sdk commented Sep 18, 2024

You can try these changes here

🛝 Playground	🌐 Website	📚 Next docs

AlitzelMendez added 2 commits

September 18, 2024 09:59


          Add rule to ruleset

978905d


          Add summary of change to ruleset

c659854

timotheeguerin reviewed

View reviewed changes

.chronus/changes/almend-Rule-2024-8-18-10-2-28.md Outdated Show resolved Hide resolved

timotheeguerin reviewed

View reviewed changes

.chronus/changes/almend-Rule-2024-8-17-16-58-23.md Outdated Show resolved Hide resolved

timotheeguerin reviewed

View reviewed changes

docs/libraries/azure-resource-manager/rules/arm-properties-type-object-no-definition.md Outdated Show resolved Hide resolved

timotheeguerin reviewed

View reviewed changes

docs/libraries/azure-resource-manager/rules/arm-properties-type-object-no-definition.md Outdated Show resolved Hide resolved

timotheeguerin reviewed

View reviewed changes

packages/typespec-azure-resource-manager/src/rules/arm-properties-type-object-no-definition.ts Outdated Show resolved Hide resolved

timotheeguerin reviewed

View reviewed changes

packages/typespec-azure-resource-manager/src/rules/arm-properties-type-object-no-definition.ts Outdated Show resolved Hide resolved

AlitzelMendez and others added 5 commits

September 18, 2024 11:27


          Apply suggestions from code review

f2dd4b5

Feedback about names and documentation

Co-authored-by: Timothee Guerin <[email protected]>


          Feedback: change name and apply rule to model level

530368a


          Add url and line to doc

b2b2a74


          Fix spelling uknow word

7c7987f


          Feedback: rename from arm-no-empty-model to no-empty-model

b65afd8

AlitzelMendez marked this pull request as ready for review

September 18, 2024 22:00

AlitzelMendez requested review from bterlson, markcowl and allenjzhang as code owners

September 18, 2024 22:00

AlitzelMendez changed the title ~~[DRAFT] Add rule for RPC-Policy-V1-03: no properties of type object without a schema~~ Add rule for RPC-Policy-V1-03: no properties of type object without a schema

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

timotheeguerin timotheeguerin left review comments

bterlson Awaiting requested review from bterlson bterlson is a code owner

markcowl Awaiting requested review from markcowl markcowl is a code owner

allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet