Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Arm LintDiff]: Add rule for RPC-Policy-V1-03: no properties of type object without a schema #1426

Open
markcowl opened this issue Aug 26, 2024 · 2 comments
Open

[Arm LintDiff]: Add rule for RPC-Policy-V1-03: no properties of type object without a schema #1426

markcowl opened this issue Aug 26, 2024 · 2 comments
Assignees
@AlitzelMendez
Labels
breaking-change A change that might cause specs or code to break feature New feature or request lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library triaged:core
Milestone
[2024] October

Comments

@markcowl
Copy link
Member

markcowl commented Aug 26, 2024 •
edited
Loading

This is a new ARM rule, moving from staging to production: PropertiesTypeObjectNoDefinition

We should disallow properties using type {} and properties using type Record
@markcowl markcowl added the lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library label Aug 26, 2024
@markcowl markcowl added breaking-change A change that might cause specs or code to break needs-area feature New feature or request and removed needs-area labels Aug 26, 2024
@markcowl markcowl mentioned this issue Aug 26, 2024
Merged
@markcowl markcowl added this to the [2024] September milestone Aug 26, 2024
@markcowl
Copy link
Member Author

est: 3

@markcowl
Copy link
Member Author

markcowl commented Sep 4, 2024

Describe the breaking change
Add a linting rule to mirror the new lintdiff rule, discouraging use of object types without properties

Back-compat design to avoid immediate breaking
Linting rule: existing specs have rule suppressed

Impact
This change affecting:

  • ARM
  • Data-plane
  • Existing specs: ~10
  • New specs
  • Emitters
  • SDK

Targeted Sprint
September

Additional information
Mirrors a new ARM lintdiff rule, so specs could not be checked in without fixing this or getting an exception

@AlitzelMendez AlitzelMendez self-assigned this Sep 12, 2024
@AlitzelMendez AlitzelMendez mentioned this issue Sep 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlitzelMendez AlitzelMendez

Labels
breaking-change A change that might cause specs or code to break feature New feature or request lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library triaged:core
Projects
None yet
Milestone
[2024] October
Development

No branches or pull requests
2 participants
@markcowl @AlitzelMendez