Wait for all of the WebSocketUpgradeResponse to accumulate in the inputBuffer before validating it #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utBuffer before validating it
sjkwak
reviewed
Nov 4, 2018
| @@ -275,7 +277,8 @@ private boolean sendToUnderlyingInput() { | |||
| private void processInput() throws TransportException { | |||
| switch (webSocketState) { | |||
| case PN_WS_CONNECTING: | |||
| if (webSocketHandler.validateUpgradeReply(inputBuffer)) { | |||
| if ((inputBuffer.remaining() > MIN_WEB_SOCKET_UPGRADE_RESPONSE_SIZE) | |||
| && webSocketHandler.validateUpgradeReply(inputBuffer)) { | |||
There was a problem hiding this comment.
Have we checked why inputBuffer didn't contain full payloads (handshake HTTP response) from a WebSocket server? Checking if the size of handshake payload is greater than 100 bytes doesn't guarantee that response header is fully retrieved. For instance, what if size is 101 and response is still partially retrieved?
|
Replaced by #12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: Azure/azure-event-hubs-java#385