Fix for IBM websockets connection chunking issue #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjkwak
approved these changes
Mar 13, 2019
| @@ -275,8 +280,13 @@ private boolean sendToUnderlyingInput() { | |||
| private void processInput() throws TransportException { | |||
| switch (webSocketState) { | |||
| case PN_WS_CONNECTING: | |||
| inputBuffer.mark(); | |||
There was a problem hiding this comment.
Thanks for fixing the issue. Can you please add a unit test which verifies the fix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we cannot validate the websocket reply, reset the buffer so existing input is unconsumed and wait for another call with more input. If the response is actually truncated or erroneous, then the open timeout higher up in the stack will eventually fire.