Skip to content

fix #69 by rolling back @azure/ms-rest-js to ^1.8.13 #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amarzavery merged 2 commits into from
Aug 2, 2019
Merged

fix #69 by rolling back @azure/ms-rest-js to ^1.8.13 #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfd22a3
fix #69 by rolling back @azure/ms-rest-js to ^1.8.13
amarzavery Aug 2, 2019
5866efe
reflect the right version in changelog
amarzavery Aug 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
# Changelog
## 2.0.4 - 2019/08/02
- Rolling back the min version of dependency `@azure/ms-rest-js` from `^2.0.3` to `^1.8.13` thereby fixing [#69](https://github.com/Azure/ms-rest-nodeauth/issues/69).
Copy link
Contributor

@ramya-rao-a ramya-rao-a Aug 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about azure/ms-rest-azure-env? The breaking changes there from major version 1 to 2 doesn't affect anybody?

Copy link
Contributor Author

@amarzavery amarzavery Aug 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That shouldn't affect anyone. It is a good breaking change. We removed a dot from the storage suffix which shouldn't have been there in the first place. This change was made after a customer filed an issue. Since it was a breaking change we updated the major version of the package. However, it is a good change and we don't expect it to cause issues to our customers since the previous code was not usable.


## 2.0.3 - 2019/07/23
- Updated min version of dependency `@azure/ms-rest-js` to `^2.0.3`.
- Updated min version of dependenct `@azure/ms-rest-azure-env` to `^2.0.0`.
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"email": "azsdkteam@microsoft.com",
"url": "https://github.com/Azure/ms-rest-nodeauth"
},
"version": "2.0.3",
"version": "2.0.4",
"description": "Azure Authentication library in node.js with type definitions.",
"keywords": [
"node",
Expand All @@ -29,7 +29,7 @@
],
"dependencies": {
"@azure/ms-rest-azure-env": "^2.0.0",
"@azure/ms-rest-js": "^2.0.3",
"@azure/ms-rest-js": "^1.8.13",
"adal-node": "^0.1.28"
},
"license": "MIT",
Expand Down Expand Up @@ -69,4 +69,4 @@
"test:unit": "mocha",
"check:packagejsonversion": "ts-node ./.scripts/checkPackageJsonVersion.ts"
}
}
}