fix #69 by rolling back @azure/ms-rest-js to ^1.8.13#70
Merged
amarzavery merged 2 commits intoAzure:masterfrom Aug 2, 2019
Merged
fix #69 by rolling back @azure/ms-rest-js to ^1.8.13#70amarzavery merged 2 commits intoAzure:masterfrom
amarzavery merged 2 commits intoAzure:masterfrom
Conversation
daviwil
approved these changes
Aug 2, 2019
ramya-rao-a
reviewed
Aug 2, 2019
| @@ -1,4 +1,7 @@ | |||
| # Changelog | |||
| ## 2.0.4 - 2019/08/02 | |||
| - Rolling back the min version of dependency `@azure/ms-rest-js` from `^2.0.3` to `^1.8.13` thereby fixing [#69](https://github.com/Azure/ms-rest-nodeauth/issues/69). | |||
Contributor
There was a problem hiding this comment.
What about azure/ms-rest-azure-env? The breaking changes there from major version 1 to 2 doesn't affect anybody?
Contributor
Author
There was a problem hiding this comment.
That shouldn't affect anyone. It is a good breaking change. We removed a dot from the storage suffix which shouldn't have been there in the first place. This change was made after a customer filed an issue. Since it was a breaking change we updated the major version of the package. However, it is a good change and we don't expect it to cause issues to our customers since the previous code was not usable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.