quick fixes (#234)

Azure · May 29, 2024 · 6bfc81d · 6bfc81d
1 parent b696b80
commit 6bfc81d
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 18 deletions.
diff --git a/src/appservice-rest/Kudu/azure-app-kudu-service.ts b/src/appservice-rest/Kudu/azure-app-kudu-service.ts
@@ -20,7 +20,7 @@ export class Kudu {
 
     constructor(scmUri: string, username: string, password: string, accessToken?: string) {
         if (accessToken === undefined) {
-            var base64EncodedCredential = (new Buffer(username + ':' + password).toString('base64'));
+            var base64EncodedCredential = (Buffer.from(username + ':' + password).toString('base64'));
             this._client = new KuduServiceClient(scmUri, "Basic " + base64EncodedCredential);
         } else {
             this._client = new KuduServiceClient(scmUri, "Bearer " + accessToken);

diff --git a/src/publishers/websiteRunFromPackageDeploy.ts b/src/publishers/websiteRunFromPackageDeploy.ts
@@ -50,7 +50,7 @@ export class WebsiteRunFromPackageDeploy {
 
     private static createBlobName(): string {
         const now: Date = new Date();
-        const time: string = `${now.getUTCFullYear()}${now.getUTCMonth() + 1}${now.getUTCDate()}${now.getUTCHours()}${now.getUTCMinutes()}${now.getUTCSeconds()}`;
+        const time: string = `${now.getUTCFullYear()}${now.getUTCMonth() + 1}${now.getUTCDate()}${now.getUTCHours()}${now.getUTCMinutes()}${now.getUTCSeconds()}${now.getUTCMilliseconds()}`;
         return `${ConfigurationConstant.BlobNamePrefix}_${time}.zip`;
     }
 

diff --git a/src/utils/funcignore.ts b/src/utils/funcignore.ts
@@ -4,6 +4,7 @@ import * as glob from 'glob';
 import * as rimraf from 'rimraf';
 import * as ignore from 'ignore';
 import { Logger } from './logger';
+import path = require('path');
 
 export class FuncIgnore {
     public static doesFuncignoreExist(working_dir: string): boolean {
@@ -32,7 +33,7 @@ export class FuncIgnore {
         const sanitizedWorkingDir: string = FuncIgnore.sanitizeWorkingDir(working_dir);
         const allFiles: string[] = glob.sync(`${sanitizedWorkingDir}/**/*`, { dot: true });
         allFiles.forEach(name => {
-            const filename = name.replace(`${working_dir}/`, '');
+            const filename = path.relative(working_dir, name);
             if (ignoreParser.ignores(filename)) {
                 try {
                     rimraf.sync(name);

diff --git a/tests/e2e/node20/package-lock.json b/tests/e2e/node20/package-lock.json
diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -5,8 +5,6 @@
         "rootDir": "./src",
         "outDir": "./lib",
         "strict": false,
-        "strictNullChecks": false,
-        "strictPropertyInitialization": false,
         "strictFunctionTypes": true,
         "noImplicitAny" : true,
         "noUnusedParameters": true,