draft init rewrite #154
draft init rewrite #154
Conversation
|
@bacongobbler, |
bacongobbler
force-pushed
the
draft-init-rewrite
branch
from
f6a7126
to
6c04f5b
Compare
|
bit of a sample (with a custom minikube build with registry addon support): |
bacongobbler
force-pushed
the
draft-init-rewrite
branch
from
6c04f5b
to
d998aa6
Compare
|
testing this feature requires the following PR: kubernetes/minikube#1583 If you don't want to build minikube from scratch, you can just run As per the new Minikube quickstart documentation. |
bacongobbler
force-pushed
the
draft-init-rewrite
branch
from
d998aa6
to
4444aee
Compare
|
testers of this PR will also require kubernetes/minikube#1603. I accidentally broke the original PR on a last-minute fix. |
|
What is your acceptance criteria for getting this merged? Any support for GKE/AWS k8s clusters (besides minikube)? Right now if the provider isn't identified the messaging can be kind of confusing: |
|
Also if I select "n" on that prompt, the ux doesn't feel quite right (draft moves on with changes instead of giving me cancel-like feedback): |
|
Yeah right now it's just minikube. Acceptance criteria for this PR is:
Azure support would be a nice one to get in, but we can add support for that in a follow-up and just roll with minikube for now. |
|
When you select "no" it should start to prompt you for manual information. That hasn't been implemented yet. Would that be ok to use or would you prefer a different UX? |
|
I like that approach.
Ping me when those changes go in! I like where this is headed. |
|
+1 |
bacongobbler
force-pushed
the
draft-init-rewrite
branch
from
4444aee
to
3706c3c
Compare
|
I've revised the installation guide to make minikube front and center, as I imagine a lot of our userbase will be running a local cluster during development rather than on a cloud provider. I'll also add some bits about how any cluster can be used, but I haven't changed the codebase to prompt on unknown cloud providers yet to show how that works out. @sgoings would you like to take a look at the installation guide and see if that works for you? |
|
Something to note: this PR cannot be merged until minikube v0.20 has been released as the |
| @@ -28,4 +28,4 @@ registry: | |||
| # For token-based logins, use | |||
| # | |||
| # $ echo '{"registrytoken":"9cbaf023786cd7"}' | base64 | |||
| authtoken: changeme | |||
| authtoken: e30K | |||
There was a problem hiding this comment.
why this change? how come we need an auth token for pulling public images?
There was a problem hiding this comment.
"e30K" is the base64 equivalent of "{}". It's actually a very weird docker behaviour in which you NEED to send an empty auth token to push an image... even on registries with no authentication (like minikube w/ an in-cluster registry). Sending a string like "changeme" just causes docker to freak out because it can't parse it into a json object.
We could just change cmd/draft/installer/config/config.go to change the authtoken string to "e30K" but I thought it'd be a good default to use an empty JSON string anyways to prevent docker from freaking out.
There was a problem hiding this comment.
See https://github.com/moby/moby/blob/254fc83cba90ed79c78f4cb0cb33aeeaff492798/client/image_push.go#L54 as an example. Even if the registry isn't backed by auth, an empty auth token still gets shipped and the v2 registry expects that.
bacongobbler
force-pushed
the
draft-init-rewrite
branch
2 times, most recently
from
a944eb8
to
46bd465
Compare
bacongobbler
force-pushed
the
draft-init-rewrite
branch
2 times, most recently
from
bf50f79
to
6ddd759
Compare
|
k, so the documentation has been rewritten with minikube in mind and the new "prompt for missing information" dialogue is available for users running on Azure/GCS/AWS/whathaveyou. Sample output: The password is hidden thanks to |
|
Some open questions:
|
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
=========================================
- Coverage 33.15% 33.06% -0.1%
=========================================
Files 18 18
Lines 1101 1104 +3
=========================================
Hits 365 365
- Misses 687 690 +3
Partials 49 49
Continue to review full report at Codecov.
|
bacongobbler
force-pushed
the
draft-init-rewrite
branch
from
6ddd759
to
e291942
Compare
bacongobbler
force-pushed
the
draft-init-rewrite
branch
from
e291942
to
f7c528e
Compare
bacongobbler
force-pushed
the
draft-init-rewrite
branch
from
f7c528e
to
c06bafa
Compare
closes #82
closes #102
closes #122
closes #152
closes #167
This is a relatively "large" PR, so here's where we are at today:
-fand--set; user will be prompted for this information instead if required--yesis available if user wants to auto-accept the defaultsingressandregistryaddons as well as ranhelm initafter the cluster was created.draft initdetects this and drops some configuration to use these addons nativelyTODO: